Skip to content

Move platforms to merged TimeAlarm wake API - #55

Open
dymk wants to merge 1 commit into
OpenDevicePartnership:mainfrom
dymk:dymk/time-alarm-merged-api
Open

dymk wants to merge 1 commit into
OpenDevicePartnership:mainfrom
dymk:dymk/time-alarm-merged-api

Conversation

@dymk

@dymk dymk commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Update embedded-services to 3ff41f5 (#968 merge) on every platform. dev-qemu was still building against the pre-merge #968 commit baf1a15, which is not on embedded-services main. Because platform-common is shared through a path dependency, all platform lockfiles move together; each is three commits ahead (#978, #976, #968).

  • dev-qemu: drive GPIO1 from a wake_requested_receiver() and select the power source through TimeAlarmService::set_power_source. Log lines are unchanged.
  • platform-common: register the mock battery service with DefaultPowerPolicyRouting, required by #976. The mock delivers no power-policy events.
  • Lockfiles change only the embedded-services revision and three new dependency edges; haf-ec-service stays at its current revision.

fmt, Clippy, build, feature-powerset check, machete, and cargo vet pass for every CI platform, plus strict Clippy for the default, time-alarm-wake, and time-alarm-power-input dev-qemu builds. On odp-platform-qemu-arm-virt main with this EC and the builder image published from odp-qemu-builder f8af0566, without RETENTION_EC_QEMU, these all pass: the thermal, battery, and TimeAlarm relay runs; CPU retention wake for AC/DC with the wake wire connected and disconnected; runtime source switching for AC and DC cold starts, with all five source changes acknowledged; and the TPM and UCSI service runs.

Closes #54

Update embedded-services to 3ff41f5, which merged the TimeAlarm source
and wake API (#968) after the battery power-policy change (#976).

Drive dev-qemu's GPIO1 from a wake_requested receiver and select the
power source through TimeAlarmService. Register the mock battery
service with the default power-policy router; the mock does not
deliver power-policy events. Keep haf-ec-service at its current
revision.

Assisted-by: GitHub Copilot:claude-opus-5.5
@dymk
dymk marked this pull request as ready for review November 10, 2026 19:52
@dymk
dymk requested a review from a team as a code owner November 10, 2026 19:52
@dymk
dymk requested review from kat-perez, maxperga-msft, rogurr and williampMSFT and a balanced review from Copilot November 10, 2026 19:52

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The upgrade changes four additional platform lockfiles despite issue #54’s scope constraint; the acceptance criteria need updating or the upgrade needs separating.

No open issues 🎉

What changed in this PR

Migrates dev-qemu to the merged TimeAlarm wake API for issue #54 and aligns shared service dependencies across platforms.

Changes:

  • Updates embedded-services to 3ff41f5 in all six lockfiles, including three new dependency edges.
  • Drives QEMU GPIO1 through wake_requested_receiver() and uses the TimeAlarmService trait for power-source selection.
  • Adds DefaultPowerPolicyRouting to the shared mock battery registration.
File Description
platform/​platform-common/​src/​mock/​battery.rs Adds the required battery power-policy routing.
platform/​platform-common/​Cargo.lock Aligns shared dependencies with the merged revision.
platform/​dev-qemu/​src/​main.rs Adopts the merged TimeAlarm wake and power-source API.
platform/​dev-qemu/​Cargo.lock Replaces the pre-merge embedded-services revision.
platform/​dev-npcx/​Cargo.lock Aligns NPCX dependencies with the shared API update.
platform/​dev-mec/​Cargo.lock Aligns MEC dependencies with the shared API update.
platform/​dev-mcxa/​Cargo.lock Aligns MCXA dependencies with the shared API update.
platform/​dev-imxrt/​Cargo.lock Aligns i.MXRT dependencies with the shared API update.

Review effort: Balanced

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dev-qemu: Move to merged TimeAlarm wake API

3 participants