Repository navigation
Conversation
Update embedded-services to 3ff41f5, which merged the TimeAlarm source and wake API (#968) after the battery power-policy change (#976). Drive dev-qemu's GPIO1 from a wake_requested receiver and select the power source through TimeAlarmService. Register the mock battery service with the default power-policy router; the mock does not deliver power-policy events. Keep haf-ec-service at its current revision. Assisted-by: GitHub Copilot:claude-opus-5.5
dymk
marked this pull request as ready for review
November 10, 2026 19:52
dymk
requested review from
kat-perez,
maxperga-msft,
rogurr and
williampMSFT
and
a balanced review from Copilot
November 10, 2026 19:52
There was a problem hiding this comment.
🔵 Needs a closer look
The upgrade changes four additional platform lockfiles despite issue #54’s scope constraint; the acceptance criteria need updating or the upgrade needs separating.
No open issues 🎉
What changed in this PR
Migrates dev-qemu to the merged TimeAlarm wake API for issue #54 and aligns shared service dependencies across platforms.
Changes:
- Updates embedded-services to
3ff41f5in all six lockfiles, including three new dependency edges. - Drives QEMU GPIO1 through
wake_requested_receiver()and uses theTimeAlarmServicetrait for power-source selection. - Adds
DefaultPowerPolicyRoutingto the shared mock battery registration.
| File | Description |
|---|---|
platform/platform-common/src/mock/battery.rs |
Adds the required battery power-policy routing. |
platform/platform-common/Cargo.lock |
Aligns shared dependencies with the merged revision. |
platform/dev-qemu/src/main.rs |
Adopts the merged TimeAlarm wake and power-source API. |
platform/dev-qemu/Cargo.lock |
Replaces the pre-merge embedded-services revision. |
platform/dev-npcx/Cargo.lock |
Aligns NPCX dependencies with the shared API update. |
platform/dev-mec/Cargo.lock |
Aligns MEC dependencies with the shared API update. |
platform/dev-mcxa/Cargo.lock |
Aligns MCXA dependencies with the shared API update. |
platform/dev-imxrt/Cargo.lock |
Aligns i.MXRT dependencies with the shared API update. |
Review effort: Balanced
RobertZ2011
approved these changes
Nov 10, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update embedded-services to
3ff41f5(#968 merge) on every platform.dev-qemuwas still building against the pre-merge #968 commitbaf1a15, which is not on embedded-services main. Becauseplatform-commonis shared through a path dependency, all platform lockfiles move together; each is three commits ahead (#978, #976, #968).dev-qemu: drive GPIO1 from awake_requested_receiver()and select the power source throughTimeAlarmService::set_power_source. Log lines are unchanged.platform-common: register the mock battery service withDefaultPowerPolicyRouting, required by #976. The mock delivers no power-policy events.haf-ec-servicestays at its current revision.fmt, Clippy, build, feature-powerset check, machete, and
cargo vetpass for every CI platform, plus strict Clippy for the default,time-alarm-wake, andtime-alarm-power-inputdev-qemubuilds. On odp-platform-qemu-arm-virt main with this EC and the builder image published from odp-qemu-builderf8af0566, withoutRETENTION_EC_QEMU, these all pass: the thermal, battery, and TimeAlarm relay runs; CPU retention wake for AC/DC with the wake wire connected and disconnected; runtime source switching for AC and DC cold starts, with all five source changes acknowledged; and the TPM and UCSI service runs.Closes #54