Repository navigation
Adopt public fields for UCSI types - #974
Merged
RobertZ2011 merged 2 commits intoNov 2, 2026
Merged
RobertZ2011 merged 2 commits into
RobertZ2011 merged 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Static review found no blocking issues in this narrowly scoped API migration; tests were not run.
No open issues 🎉
What changed in this PR
Updates TCPM service integration with embedded-usb-pd’s public UCSI fields and connector-bearing command arguments.
Changes:
- Replaces UCSI getters and setters with direct field access.
- Maps global connector IDs to local ports using
MapPort. - Adapts integration tests and the std mock controller to the updated API.
| File | Description |
|---|---|
tcpm-service/tests/ucsi.rs |
Updates command construction, assertions, and shared helpers. |
tcpm-service/src/service/ucsi.rs |
Migrates field access and local command mapping. |
tcpm-service/src/service/power.rs |
Reads notification flags directly. |
examples/std/src/lib/type_c/mock_controller.rs |
Updates connector logging and command matching. |
Review effort: Balanced
RobertZ2011
force-pushed
the
pull-in-embedded-usb-pd-ucsi-no-bincode
branch
from
October 19, 2026 18:23
047c3d6 to
4596864
Compare
Cargo Vet Audit Passed
|
RobertZ2011
force-pushed
the
pull-in-embedded-usb-pd-ucsi-no-bincode
branch
from
October 19, 2026 18:40
4596864 to
ec448a4
Compare
RobertZ2011
marked this pull request as ready for review
October 19, 2026 18:45
RobertZ2011
requested review from
asasine,
felipebalbi,
gjpmsft,
jerrysxie,
kurtjd,
makubacki and
williampMSFT
October 19, 2026 18:46
RobertZ2011
enabled auto-merge (squash)
October 19, 2026 18:46
jerrysxie
previously approved these changes
Oct 20, 2026
felipebalbi
reviewed
Oct 21, 2026
RobertZ2011
marked this pull request as draft
October 21, 2026 20:16
auto-merge was automatically disabled
October 21, 2026 20:16
Pull request was converted to draft
RobertZ2011
force-pushed
the
pull-in-embedded-usb-pd-ucsi-no-bincode
branch
from
October 27, 2026 15:49
2d6aa9e to
45def63
Compare
RobertZ2011
marked this pull request as ready for review
October 27, 2026 16:10
RobertZ2011
enabled auto-merge (squash)
October 27, 2026 16:10
RobertZ2011
force-pushed
the
pull-in-embedded-usb-pd-ucsi-no-bincode
branch
2 times, most recently
from
October 27, 2026 21:43
706ed49 to
14efe9d
Compare
kurtjd
approved these changes
Oct 27, 2026
tullom
approved these changes
Oct 29, 2026
embedded-usb-pd now exposes UCSI struct fields directly instead of through getters and setters, and LPM commands carry the connector number in their arguments. Update tcpm-service, its tests and the std example to use the fields, and retarget LPM commands to the local port with MapPort. Assisted-by: GitHub Copilot:claude-sonnet-5.5 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: c9a94a93-729f-451c-b08e-78887f5542e8
RobertZ2011
force-pushed
the
pull-in-embedded-usb-pd-ucsi-no-bincode
branch
from
November 2, 2026 21:31
14efe9d to
93f57bb
Compare
felipebalbi
approved these changes
Nov 2, 2026
RobertZ2011
merged commit Nov 2, 2026
4051b1d
into
OpenDevicePartnership:main
16 of 32 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
embedded-usb-pd now exposes UCSI struct fields directly instead of through getters and setters, and LPM commands carry the connector number in their arguments. Update tcpm-service, its tests and the std example to use the fields, and retarget LPM commands to the local port with MapPort.
Assisted-by: GitHub Copilot:claude-sonnet-5.5