check port id range #251
Merged
check port id range #251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavel-kirienko
requested changes
Aug 12, 2025
libcanard/canard.c
Outdated
| #define CRC_INITIAL 0xFFFFU | ||
| #define CRC_RESIDUE 0x0000U | ||
| #define CRC_SIZE_BYTES 2U | ||
| #define PORT_ID_MINIMUM 49152 |
libcanard/canard.c
Outdated
Comment on lines
1390
to
1391
| (((transfer_kind == CanardTransferKindMessage) && (port_id <= CANARD_SUBJECT_ID_MAX)) || | ||
| (port_id <= CANARD_SERVICE_ID_MAX))) |
Member
There was a problem hiding this comment.
Please extract these into a port_id_ok variable to enhance readability, and remove the extra blank line.
|
pavel-kirienko
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #221