Issue-1757 move saml id generator#1993
Open
kayjoosten wants to merge 6 commits into
Open
Conversation
…d DefaultIdGenerator
…rom legacy interface
Contributor
|
\EngineBlock_Saml2_IdGenerator_Default and \EngineBlock_Saml2_IdGenerator still need to be deleted I think. |
johanib
reviewed
May 11, 2026
Contributor
johanib
left a comment
johanib
left a comment
There was a problem hiding this comment.
Looks good, as discussed.
|
|
||
| final class DefaultIdGenerator implements IdGenerator | ||
| { | ||
| public function generate(string $prefix = 'EB', string $usage = self::ID_USAGE_OTHER): string |
Contributor
There was a problem hiding this comment.
$usage is unused. Should we keep it?
…l2_IdGenerator_Default classes The new OpenConext\EngineBlock\Saml2\IdGenerator interface and DefaultIdGenerator implementation have replaced these classes. All references updated in the PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.