fix: prevent repeated template sequence names#482
Open
manulera wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to prevent duplicate template sequence names within the same workspace (including case-insensitive duplicates), aligning API behavior with a stronger workspace-scoped uniqueness rule.
Changes:
- Add a workspace-scoped, case-insensitive uniqueness enforcement for template sequence names (API-side checks + DB constraint).
- Update sequence patching to enforce the same constraint when renaming template sequences.
- Add tests covering duplicate-name creation/rename scenarios and cross-workspace allowance.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
uv.lock |
Bumps editable package versions to 1.6.1. |
packages/opencloning-db/tests/test_template_sequences.py |
Adds coverage for 409 conflicts on duplicate template sequence names (incl. case-insensitive) and validates cross-workspace behavior. |
packages/opencloning-db/src/opencloning_db/routers/template_sequences.py |
Enforces name availability pre-check and converts uniqueness-related IntegrityError into a 409 response. |
packages/opencloning-db/src/opencloning_db/routers/sequences.py |
Enforces template-sequence name availability on rename and handles uniqueness IntegrityError as 409 for template sequences. |
packages/opencloning-db/src/opencloning_db/models.py |
Adds a partial unique index for template sequence names (case-insensitive) and introduces helper functions to check/raise on conflicts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+208
to
+216
| __table_args__ = ( | ||
| Index( | ||
| 'uq_input_entity_template_sequence_workspace_name', | ||
| 'workspace_id', | ||
| text('lower(name)'), | ||
| unique=True, | ||
| postgresql_where=text("type = 'template_sequence'"), | ||
| ), | ||
| ) |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #482 +/- ##
==========================================
- Coverage 98.29% 98.12% -0.18%
==========================================
Files 59 59
Lines 4235 4258 +23
==========================================
+ Hits 4163 4178 +15
- Misses 72 80 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.