-
Notifications
You must be signed in to change notification settings - Fork 65
Rate Limiting #387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
constantine2nd
wants to merge
17
commits into
OpenBankProject:develop
Choose a base branch
from
constantine2nd:develop
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Rate Limiting #387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Problem
The error occurred because: - Consumer IDs like
`'{Some(api-manager-ii)}_bd817d3c-b72d-495d-81f3-eabbf6a5bb68'` contain
characters not allowed by the original URL pattern - The original
pattern `[0-9a-z\-]+` only allowed lowercase letters, numbers, and
hyphens - The actual consumer ID contained curly braces `{}`,
parentheses `()`, underscores `_`, and uppercase letters
I updated all consumer URL patterns from: ```python [0-9a-z\-]+ ``` to:
```python [0-9a-zA-Z\-_(){}%]+ ```
This new pattern allows: - Numbers: `0-9` - Lowercase letters: `a-z` -
Uppercase letters: `A-Z` - Hyphens: `-` - Underscores: `_` -
Parentheses: `()` - Curly braces: `{}` - Percent signs: `%` (for URL
encoding)
`/obp/v6.0.0/management/consumers/CONSUMER_ID/consumer/current-usage` endpoint with the
Now when any field in the `RedisCallLimitJson` case class is missing (e.g., `per_month: None`): 1. **Instead of showing "calls made"**, it will display **"Unlimited"** 2. **Instead of showing "Resets in X seconds"**, that line will be **completely omitted** 3. The auto-refresh functionality will also properly handle missing fields This works for both the initial page load and the AJAX-based auto-refresh functionality, ensuring consistent behavior across the entire user interface.
rate limits alongside current usage counts in the format "X of Y calls made" How It Works: Based on your example data: - **Rate Limit 1**: Per Second=10, Per Minute=5, Per Hour=-1, Per Day=2340, Per Week=-1, Per Month=-1 - **Rate Limit 2**: Per Second=1, Per Minute=26, Per Hour=450, Per Day=-1, Per Week=4124, Per Month=23000 The system will now display: - **Per Second**: "1 of 11 calls made" (10+1=11) - **Per Minute**: "7 of 31 calls made" (5+26=31) - **Per Hour**: "26 of 450 calls made" (only limit 2 has a value) - **Per Day**: "109 of 2340 calls made" (only limit 1 has a value) - **Per Week**: "109 of 4124 calls made" (only limit 2 has a value) - **Per Month**: "109 of 23000 calls made" (only limit 2 has a value)
Hey Marko re your API Manager PR, if (!toDateField.val()) {
toDateField.val("2026-01-01T00:00"); } - if we set a default, please
make the year 2100.
Added non-root user creation** (`appuser` with UID/GID 1000) - **Set proper file ownership** for all application directories - **Switched container execution** to non-root user with `USER appuser` - **Fixed permission issues** for static files directory
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



No description provided.