fix: Fix what the navigation hide interaction affects all pages#580
Merged
zxrys merged 1 commit intoOpenBMB:mainfrom Mar 15, 2026
Merged
fix: Fix what the navigation hide interaction affects all pages#580zxrys merged 1 commit intoOpenBMB:mainfrom
zxrys merged 1 commit intoOpenBMB:mainfrom
Conversation
zxrys
approved these changes
Mar 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PR
#576
Description
This PR addresses an issue where the sidebar's auto-hide feature (on scroll), introduced in a previous update, was globally affecting pages beyond the
Tutorialscreen. This led to unintended layout shifts, such as unnecessary margins on other pages.Technical Considerations & Decision Making
I evaluated two primary approaches to resolve this:
Option 1: Hardcoding the hide logic for the Tutorial page only.
Option 2: Enabling the Sidebar component to dynamically determine behavior based on route metadata.
Sidebarcan independently decide whether to activate the scroll-hide logic based on the current context.Changes
Utilizing Vue Router Meta Fields:
meta: { hideNavOnScroll: true }to the/tutorialroute inrouter/index.js.Performance Optimization (Dynamic Event Listener Allocation):
handleScroll) that was previously attached upon the Sidebar mounting to prevent unnecessary computation and potential memory leaks.watchto check themeta.hideNavOnScrollvalue only once during route transitions.removeEventListener) when navigating away to other pages.