Conversation
philippitts
force-pushed
the
support-ganglion-v3-firmware-detection
branch
6 times, most recently
from
4ccca00 to
dc0d6c1
Compare
philippitts
force-pushed
the
support-ganglion-v3-firmware-detection
branch
from
dc0d6c1 to
f444bfe
Compare
retiutut
left a comment
retiutut
left a comment
There was a problem hiding this comment.
Need clarification on a few places. Other comments are towards approval.
java-package/openbci_gui_helpers/src/main/java/openbci_gui_helpers/GUIHelper.java
Show resolved
Hide resolved
java-package/openbci_gui_helpers/src/main/java/openbci_gui_helpers/GUIHelper.java
Outdated
Show resolved
Hide resolved
| public static void main(String[] args) throws GanglionError { | ||
| GanglionDevice[] devices = GUIHelper.scan_for_ganglions(args[0], 3); | ||
| for (GanglionDevice device : devices) { | ||
| System.out.println("Identifier = " + device.identifier + ", Mac Address = " + device.mac_address |
There was a problem hiding this comment.
I take it this test is passing? Didn't see a shared test result.
There was a problem hiding this comment.
It passes for me, but it would be better if you also ran the test on your side so we can confirm it works on more than just my device.
| public static void main(String[] args) throws GanglionError { | ||
| GanglionDevice[] devices = GUIHelper.scan_for_ganglions(3); | ||
| for (GanglionDevice device : devices) { | ||
| System.out.println("Identifier = " + device.identifier + ", Mac Address = " + device.mac_address |
There was a problem hiding this comment.
It passes for me, but it would be better if you also ran the test on your side so we can confirm it works on more than just my device.
| std::string identifier = peripheral.identifier (); | ||
|
|
||
| if (strncmp (identifier.c_str (), "Ganglion", 8) == 0 || | ||
| strncmp (identifier.c_str (), "Simblee", 7) == 0) |
There was a problem hiding this comment.
Why are we still checking for the name here?
There was a problem hiding this comment.
The algorithm goes something like this:
- Scan for all devices
- For each found device check if it's a Ganglion (which means it's identifier has either Ganglion or Simblee)
- For each found Ganglion, temporarily connect and get the software revision string which describes the firmware version
On MacOS the device identifier is still Simblee - that hasn't changed. The fix is that we don't use the device identifier to determine the firmware version. We use the actual Software Revision Bluetooth characteristic advertised by the firmware. Note that we can't check that characteristic when using the dongle, so it's still important to have the firmware version in the advertised name for those connections.
When using the dongle, I believe the identifier is reported correctly on MacOS (though this is worth double checking).
|
@retiutut can you test on your MacOS machine? I don't have access to one at the moment. |
retiutut
force-pushed
the
support-ganglion-v3-firmware-detection
branch
from
c05ea75 to
91082ff
Compare
2 participants
No description provided.