Open
Conversation
GUI v7.0.0 - Alpha 0
Update analog read value range
…ting ourApplet variable and clean up legacy comments in Widgets
…Test driven with W_Template
…s and apply this to TimeSeries Widget
…dability and maintainability)
…e issues that cannot be easily fixed #1243
GUI v7 - Second major refactor
…orrect-at-low-resistances Fix Cyton impedance check board configuration
There was a problem hiding this comment.
Pull Request Overview
This PR introduces the "GUI v7 Alpha" update with enhancements to board data handling, new enums for various scales, adjustments to ADS1299 settings, updates to networking and LSL test scripts, and changes to CI/CD workflows.
- Added a null-check and marker channel naming in Board.pde
- Introduced new enum types and updated ADS1299 settings with additional fields and method signature changes
- Updated UDP/LSL scripts and CI/CD workflows for deployment consistency
Reviewed Changes
Copilot reviewed 185 out of 185 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| OpenBCI_GUI/Board.pde | Added a null-check for dataThisFrame and set a new marker channel name |
| OpenBCI_GUI/BandPowerEnums.pde | Added new enums for band power configurations |
| OpenBCI_GUI/AuxDataBoard.pde | Removed the AuxDataBoard interface |
| OpenBCI_GUI/AuditoryNeurofeedback.pde | Updated the file path for loading audio files |
| OpenBCI_GUI/AnalogReadEnums.pde & AccelerometerEnums.pde | Introduced new enums for analog and accelerometer scales |
| OpenBCI_GUI/ADS1299SettingsBoard.pde | Added new fields (previousSrb1), updated method signatures, and added new helper methods |
| Networking-Test-Kit/UDP/* & LSL/* | Updated UDP ports, buffer sizes, and added several new LSL data and testing scripts |
| .github/workflows/* | Removed and updated workflows for building and deploying on Windows, macOS, and Linux |
Comments suppressed due to low confidence (2)
Networking-Test-Kit/UDP/udp_receive.py:20
- Consider catching Exception instead of BaseException to avoid intercepting system-exiting exceptions such as KeyboardInterrupt or SystemExit.
except BaseException as e:
OpenBCI_GUI/ADS1299SettingsBoard.pde:318
- Changing the signature of revertToLastValues from a void method to one that returns a boolean is a breaking change; please ensure that all downstream usages are updated accordingly and that the method's behavior is well documented.
public boolean revertToLastValues(int chan) {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes many things!
Other specific issues that this resolves:
Fixes #1243
Fixes #1252