Open
Conversation
Used Claude Code to analyze the driver and it found and fixed numerous issues:
- Cached profile to reduce disk reads
- Removed an access mutex that was superfluous since we were already using lock {} at a lower level
- Fixed the :SC# command to return "1"
- Fixed sending the :Q# command (did not have trailing #, which probably caused the spurious NINA exception)
- Cached the NovaS31 COM object from ASCOM, instead of instantiating and tearing it down all the time.
- Protected the version against multi-threaded race condition.
- Saved the tracking state per axis (probably not needed, but safer).
- Optimized SideOfPier calculation to make far fewer calls to the mount and fixed a numerical wrap issue.
- Made the drivers UTCDate return the UTC date from the mount.
- Fixed the PollUntilZero function to have a timeout of 60s instead of waiting for all eternity in case of protocol issue. Also made it poll every 500ms instead of 1000ms
- Split the exception handling for connection vs. other issue in the Setup dialog
- Fixed a few Index-Out-of-range bugs in the Setup Dialog.
- Added checks to :GX# processing to make sure we got a full answer.
ClutchplateDude
requested review from
andre-stefanov,
jilaypandya and
julianneswinoga
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Used Claude Code to analyze the driver and it found and fixed numerous issues:
lock {}at a lower level:SC#command to return"1":Q#command (did not have trailing#, which probably caused the spurious NINA exception)SideOfPiercalculation to make far fewer calls to the mount and fixed a numerical wrap issue.UTCDatereturn the UTC date from the mount.PollUntilZerofunction to have a timeout of 60s instead of waiting for all eternity in case of protocol issue. Also made it poll every 500ms instead of 1000ms:GX#processing to make sure we got a full answer.