fix: implement missing cmd_tasks; add import-integrity guards and release alerting#262
Merged
Conversation
…ease alerting Ecosystem rollout of the #999 guards (see openadapt-ml#64, OpenAdapt#1002): - tests/test_import_integrity.py: AST-based phantom-import and phantom-kwarg detection across the whole package, including imports inside function bodies - The new guard immediately found one live bug: `oa evals tasks` (a registered, documented subcommand) imported cmd_tasks from benchmarks/cli.py, which never existed - the command has always crashed with ImportError. Implemented cmd_tasks using the mock adapter (lists 154-task WAA catalog locally, supports --domain, no VM required) - release.yml: file/append a GitHub issue when the release workflow fails, so PyPI cannot silently go stale (openadapt-ml's releases failed silently Mar-Jun 2026) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
abrichr
force-pushed
the
test/import-integrity
branch
from
daebca1 to
2a24d17
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ecosystem rollout of the #999-class guards (companions: OpenAdaptAI/openadapt-ml#64 which caught 8 latent bugs, OpenAdaptAI/OpenAdapt#1002 which caught 3).
from x import y(including inside function bodies) resolves, and that kwargs passed to internal functions exist in their signatures. Runs in ~1.6s.oa evals tasks— a registered, documented subcommand — importedcmd_tasksfrombenchmarks/cli.py, which never existed. The command has always crashed with ImportError. Implemented it usingWAAMockAdapter.list_tasks()(works locally, supports--domain, no VM needed). Verified: lists 20 mock tasks end to end.Only one phantom in 175K LOC — this repo is in much better shape than its siblings, consistent with being the actively-maintained one.
Verification
python -m openadapt_evals.cli.main evals tasksruns end to end🤖 Generated with Claude Code