Repository navigation
Conversation
Main is red: launcher run-ci fails test_listed_files_are_within_budget. #2134, #1924, #2127, #1880 and #1905 grew these files after #1510 set the budgets: runtime/replayer.py 19861->19873, __main__.py 14487->14501, qualification.py 5882->5963, ir.py 6578->6580. Signed-off-by: abrichr <richard.abrich@mldsai.com>
Member
Author
|
Codex review: APPROVE at bcee29b. The only changed file is DECOMPOSITION.md, and each new budget equals the file's actual line count: 19873, 14501, 5963 and 6580. |
Member
Author
|
Superseded by #1956, which merged the same four budgets plus the moved import-debt coordinates and turned main green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main's launcher
run-cifailstests/test_file_size_ratchet.py::test_listed_files_are_within_budget(Python CI on main 5680b40). Merges after #1510 set the budgets grew four files:runtime/replayer.py__main__.pyqualification.pyir.pyThe growth came from #2134 (
qualification.py, the certified-bundle digest fix), #1924, #2127, #1880 and #1905. This PR raises the four budgets inpackages/flow/docs/design/DECOMPOSITION.mdto the current line counts and changes no code.check_file_size_ratchet.pypasses andtest_file_size_ratchet.pypasses 8/8.