Repository navigation
Conversation
Contributor
Author
|
JDK 25 is the latest LTS jdk, so i want to add support for it :) |
Contributor
There was a problem hiding this comment.
All reported issues were addressed
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
Contributor
There was a problem hiding this comment.
All reported issues were addressed
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
Contributor
Author
|
@wing328 can you have a look at this? JDK25 is LTS :) Edit: i see some tasks are failing, will look into it :) |
Contributor
Author
|
There is a version compatability, in guess what, Kotlin ;) This build will succeed once #25246 gets merged ;) |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
Summary by cubic
Adds JDK 25 to the Linux and Windows GitHub Actions CI test matrices and bumps Gradle to 9.1.0 and JaCoCo to 0.8.14, both required for JDK 25 support.
ubuntu-latestandwindows-latestalongside JDK 11 and 17.Potential issue
pom.xmlnow definesjackson.versionandjackson-annotations.versiontwice with conflicting values (2.21.4/2.21 and 2.21.8/2.22); the later definitions win, but the duplicates should be cleaned up.Written for commit bd36c93. Summary will update on new commits.