[SPRING] Improve jspecify Nullable for all args constructor and fluent setters - #24563
Draft
jpfinne wants to merge 15 commits into
Draft
[SPRING] Improve jspecify Nullable for all args constructor and fluent setters#24563jpfinne wants to merge 15 commits into
jpfinne wants to merge 15 commits into
Conversation
merge master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
Summary by cubic
Improved JSpecify
@Nullablehandling in Spring generators: we now annotate all-args constructor params and fluent setters, and place annotations correctly inside qualified types and generics. This fixes issues with enums, lists, and SpringResource, and updates samples/tests; Spring Boot 4 output now usesjava.time.Instantwhere configured.New Features
useJspecify=true, generate@Nullableon all-args constructor parameters and fluent chain setters in Spring POJOs.nullableArgumentWithEnum.mustacheto support enum datatypes in constructor/setter arguments.Bug Fixes
@Nullablewithin qualified types and generics by improvingjSpecifyDatatype(e.g.,java.time.@Nullable Instant,@Nullable List<java.time.Instant>).spring-boot-4-jspecify.yamltype mappings:OffsetDateTime->java.time.Instant,BigDecimal->java.math.BigDecimal; expanded tests and regenerated samples.Written for commit 9fdd676. Summary will update on new commits.