Conversation
80ccb69 to
c3766cd
Compare
There was a problem hiding this comment.
1 issue found and verified against the latest diff
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
|
please resolve the merge conflicts when you've time |
Resolved. |
c75169d to
80f02f7
Compare
|
I have identified some issues with the patch related to comma handling. I am working on a fix. |
80f02f7 to
b85a6a1
Compare
|
I think this is ready. |
b85a6a1 to
694ca42
Compare
|
Rebased. |
694ca42 to
3a6d6c9
Compare
3a6d6c9 to
68697cf
Compare
|
Rebased. |
|
@wing328 Is there a chance this can be included in the next release? |
|
thanks for the PR cc Spring technical committee: @cachescrubber (2022/02) @welshm (2022/02) @MelleD (2022/02) @atextor (2022/02) @manedev79 (2022/02) @javisst (2022/02) @borsch (2022/02) @banlevente (2022/02) @Zomzog (2022/09) @martin-mfg (2023/08) @KannaKim (2026/07) to see if they've any question/feedback. |
|
Is there anything I can do to push this through? The bug is real and this change fixes it. |
This fixes #24063. This is an alternative to #24064. This utilizes JavaParser instead of regular expressions to extract the information it needs.
Summary by cubic
Fixes x-spring-provide-args: replaces regex parsing with JavaParser and forwards provided args across API interfaces, controllers, and delegates in all mapping modes. Previously, provided args were not reliably parsed or passed to delegates; now they are parsed as Java parameters, imports are generated, and signatures/ordering are consistent.
Parse with
com.github.javaparserand auto-import; simplify fully qualified annotation and generic type names (incl. nested generics).Emit annotated parameters for interfaces/controllers; strip annotations in delegates. Add vendor extensions
springProvideArgsNamesandspringProvideArgsDelegate; updateapi.mustache,apiController.mustache, andapiDelegate.mustacheto pass args by name, includingapi_interfaceand interface-only modes.Preserve Pageable position and fix commas/ordering with request context, reactive, and provided args. Add tests covering with/without provide-args, pageable, reactive, controller-to-delegate, and
api_interface.Dependencies: move
com.github.javaparser:javaparser-coreto compile scope.Written for commit 68697cf. Summary will update on new commits.