feat(openapi, openapi-yaml): add sortOutput option#24037
Draft
Picazsoo wants to merge 1 commit into
Draft
Conversation
Add a new 'sortOutput' generator option to the 'openapi' (JSON) and 'openapi-yaml' (YAML) documentation generators that produces a deterministically ordered spec: - Paths are sorted alphabetically by URL - Schemas, parameters, requestBodies, responses, headers, examples, links, callbacks and securitySchemes are sorted alphabetically by name - HTTP methods within each path are ordered by the classical convention: GET, PUT, POST, DELETE, OPTIONS, HEAD, PATCH, TRACE Implementation details: - OpenAPISorter: replaces Paths and all Components maps with TreeMaps - PathItemSerializer: custom Jackson serializer writing operations in classical HTTP method order (only registered when sortOutput=true) - SerializerUtils: overloaded toJsonString/toYamlString with sortOutput flag; createModule(boolean) registers PathItemSerializer when true - OpenAPIGenerator / OpenAPIYamlGenerator: wire the new option through to the serializer Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
1 issue found across 8 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="modules/openapi-generator/src/test/java/org/openapitools/codegen/yaml/YamlGeneratorTest.java">
<violation number="1" location="modules/openapi-generator/src/test/java/org/openapitools/codegen/yaml/YamlGeneratorTest.java:231">
P2: indexOf-based ordering tests silently pass when expected operations are missing due to -1 comparison</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
|
|
||
| // HTTP method order — GET before POST in /zebra (spec has POST first) | ||
| int zebraBlock = yaml.indexOf("/zebra:"); | ||
| Assert.assertTrue(yaml.indexOf("get:", zebraBlock) < yaml.indexOf("post:", zebraBlock), |
Contributor
There was a problem hiding this comment.
P2: indexOf-based ordering tests silently pass when expected operations are missing due to -1 comparison
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At modules/openapi-generator/src/test/java/org/openapitools/codegen/yaml/YamlGeneratorTest.java, line 231:
<comment>indexOf-based ordering tests silently pass when expected operations are missing due to -1 comparison</comment>
<file context>
@@ -185,4 +185,55 @@ public void testIssue19929() throws Exception {
+
+ // HTTP method order — GET before POST in /zebra (spec has POST first)
+ int zebraBlock = yaml.indexOf("/zebra:");
+ Assert.assertTrue(yaml.indexOf("get:", zebraBlock) < yaml.indexOf("post:", zebraBlock),
+ "GET must appear before POST within /zebra");
+
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new 'sortOutput' generator option to the 'openapi' (JSON) and 'openapi-yaml' (YAML) documentation generators that produces a deterministically ordered spec:
Implementation details:
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
Summary by cubic
Adds a
sortOutputoption to theopenapiandopenapi-yamlgenerators to produce deterministic specs. Paths and components are sorted, and HTTP methods are written in a standard order to reduce noisy diffs.New Features
sortOutput(default: false) foropenapiandopenapi-yaml.Migration
-p sortOutput=true(or via additionalProperties).Written for commit fbef10f. Summary will update on new commits.