[KOTLIN-SPRING/KOTLIN-CLIENT] BUG - fix json deserialization when kotlin attribute name differs from json attribute name#24036
Open
Picazsoo wants to merge 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
No issues found across 255 files
Note: This PR contains a large number of files. cubic only reviews up to 100 files per PR, so some files may not have been reviewed. cubic prioritizes the most important files to review.
On a pro plan you can use ultrareview for larger PRs.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using e.g.
nameMappingsor just depending on the generator's substitution logic to safely escape json properties names for kotlin parameters, the currently generated@get:JsonProperty("...")is not sufficient to allow safe deserialization as it only handles serialization via the getter association. Hence I added also@param:JsonProperty("...")to also allow proper deserialization.PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
Summary by cubic
Fixes Jackson deserialization in generated Kotlin models by adding @param:JsonProperty so constructor params bind to the original JSON keys. Models now deserialize correctly when fields are renamed via name mappings or auto-renamed (e.g., digit-starting names).
kotlin-clientandkotlin-springtemplates for required and optional vars.nameMappingsand backtick-escaped identifiers.Written for commit d1976d7. Summary will update on new commits.