Skip to content

[Ruby] Minor code improvement#23196

Merged
wing328 merged 2 commits intomasterfrom
ruby-code-improve
Mar 10, 2026
Merged

[Ruby] Minor code improvement#23196
wing328 merged 2 commits intomasterfrom
ruby-code-improve

Conversation

@wing328
Copy link
Member

@wing328 wing328 commented Mar 10, 2026

Minor code improvements for ruby client generator based on SonarCube report

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Improves Ruby client generator code quality and sample coverage. Switches to IllegalArgumentException for invalid HTTP libraries, simplifies string handling, and adds tests/samples for -1 enum values.

  • Refactors
    • Throw IllegalArgumentException when HTTP library is not faraday, typhoeus, or httpx.
    • Replace String.replaceAll with replace for literals; use isEmpty; minor comment and log-level tweaks.
    • Type additionalProperties as Schema<?>; remove unused toApiName override.
    • Add -1 to OuterEnumInteger in test spec; generate NMINUS_1 in Ruby clients and update docs/samples.

Written for commit b51cbb6. Summary will update on new commits.

@wing328 wing328 added this to the 7.21.0 milestone Mar 10, 2026
@wing328 wing328 added Client: Ruby Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. labels Mar 10, 2026
@wing328 wing328 marked this pull request as ready for review March 10, 2026 16:58
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 9 files

@wing328 wing328 merged commit 274510c into master Mar 10, 2026
15 of 16 checks passed
@wing328 wing328 deleted the ruby-code-improve branch March 10, 2026 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Client: Ruby Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant