Skip to content

fix(python-flask): validate byte length for format:byte fields #23177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1cbyc wants to merge 1 commit into
base: master
Choose a base branch
from
+26 −0
Open

fix(python-flask): validate byte length for format:byte fields #23177

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions modules/openapi-generator/src/main/resources/python-flask/model.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,12 +130,38 @@ class {{classname}}(Model):
{{/required}}
{{#hasValidation}}
{{#maxLength}}
{{#isByteArray}}
if {{name}} is not None:
import base64
try:
decoded_length = len(base64.b64decode({{name}}))
if decoded_length > {{maxLength}}:
raise ValueError("Invalid value for `{{name}}`, byte length must be less than or equal to `{{maxLength}}`") # noqa: E501
except (TypeError, ValueError, base64.binascii.Error):
# If it's not valid base64, other validation will catch it
pass
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot Mar 8, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: Byte-array length validation silently skips invalid base64/type errors, allowing malformed format:byte values to bypass validation.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At modules/openapi-generator/src/main/resources/python-flask/model.mustache, line 142:

<comment>Byte-array length validation silently skips invalid base64/type errors, allowing malformed `format:byte` values to bypass validation.</comment>

<file context>
@@ -130,12 +130,38 @@ class {{classname}}(Model):
+                    raise ValueError("Invalid value for `{{name}}`, byte length must be less than or equal to `{{maxLength}}`")  # noqa: E501
+            except (TypeError, ValueError, base64.binascii.Error):
+                # If it's not valid base64, other validation will catch it
+                pass
+{{/isByteArray}}
+{{^isByteArray}}
</file context>
Suggested change
pass
raise ValueError("Invalid value for `{{name}}`, must be valid base64-encoded data") # noqa: E501
Fix with Cubic

Copy link
Member

@wing328 wing328 Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR.

@1cbyc can you please review this feedback when you've time?

{{/isByteArray}}
{{^isByteArray}}
if {{name}} is not None and len({{name}}) > {{maxLength}}:
raise ValueError("Invalid value for `{{name}}`, length must be less than or equal to `{{maxLength}}`") # noqa: E501
{{/isByteArray}}
{{/maxLength}}
{{#minLength}}
{{#isByteArray}}
if {{name}} is not None:
import base64
try:
decoded_length = len(base64.b64decode({{name}}))
if decoded_length < {{minLength}}:
raise ValueError("Invalid value for `{{name}}`, byte length must be greater than or equal to `{{minLength}}`") # noqa: E501
except (TypeError, ValueError, base64.binascii.Error):
# If it's not valid base64, other validation will catch it
pass
{{/isByteArray}}
{{^isByteArray}}
if {{name}} is not None and len({{name}}) < {{minLength}}:
raise ValueError("Invalid value for `{{name}}`, length must be greater than or equal to `{{minLength}}`") # noqa: E501
{{/isByteArray}}
{{/minLength}}
{{#maximum}}
if {{name}} is not None and {{name}} >{{#exclusiveMaximum}}={{/exclusiveMaximum}} {{maximum}}: # noqa: E501
Expand Down
Loading