[Java] Apply Same License-Header in All Java Generators#23173
Draft
Chrimle wants to merge 1 commit intoOpenAPITools:masterfrom
Draft
[Java] Apply Same License-Header in All Java Generators#23173Chrimle wants to merge 1 commit intoOpenAPITools:masterfrom
Chrimle wants to merge 1 commit intoOpenAPITools:masterfrom
Conversation
Signed-off-by: Chrimle <28791817+Chrimle@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies the same License-header to all generated Java classes, regardless of which Java generator is used. This is already the case for the still-maintained Java generators. For other generators, the resulting Java classes will have slightly different license headers. These are;
apexandjava-undertow-server. This should be considered "internal refactoring", and is only aimed at improving maintainability.PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)Summary by cubic
Unifies the license header across all Java generators by switching to a single shared template and removing generator-specific
licenseInfo.mustachefiles. This standardizes generated headers and reduces maintenance; changes are limited to comment headers.licenseInfo.mustachefiles and routed all Java generators to the shared license header.Written for commit 700a0d2. Summary will update on new commits.