Skip to content

Conversation

@eddiesholl
Copy link
Contributor

@eddiesholl eddiesholl commented Oct 26, 2025

These changes allow the generated client for php and python to support endpoints configured with mTLS. It means users can get a successful request to go through without needing to make any edits to the generated code in these 2 languages.

This fixes the previously raised issue #12776 in a limited way, for just these languages. The same change could be made to all the other generators, I'm just making the enhancements I need for now.

PHP: @jebentier @dkarlovi @mandrean @jfastnacht @ybelenko @renepardon
Python: @cbornet @tomplus @krjakbrjak @fa0311 @multani

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member

wing328 commented Oct 27, 2025

thanks for the PR

did you test this fix locally to confirm it works for your use cases?

@eddiesholl
Copy link
Contributor Author

thanks for the PR

did you test this fix locally to confirm it works for your use cases?

Yes, I built the generator locally and ran a generation using the built jar. I was able to get the generated client for php and python to make an mtls request out of the box

@wing328
Copy link
Member

wing328 commented Oct 28, 2025

thanks for the details

PR merged.

thanks for the contribution.

@wing328 wing328 merged commit 68b0dfe into OpenAPITools:master Oct 28, 2025
67 of 68 checks passed
@wing328 wing328 added this to the 7.17.0 milestone Oct 28, 2025
rajvesh pushed a commit to rajvesh/openapi-generator that referenced this pull request Dec 25, 2025
… templates (OpenAPITools#22229)

* Expose mtls config params in python template

* Expose certFile and keyFile configuration items to support mtls in php generated client

* Regenerate of examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants