Protocol implementation #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently working on implementation Signed-off-by: Open592 Developer <uss@open592.com>
Matches it's function within the pipeline Signed-off-by: Open592 Developer <uss@open592.com>
Signed-off-by: Open592 Developer <uss@open592.com>
Signed-off-by: Open592 Developer <uss@open592.com>
Fixes a bug where we weren't serving groups Signed-off-by: Open592 Developer <uss@open592.com>
cache library doesn't seem to do this check in it's root `data` method. So we will do it explicitly ourselves. I might be missing something, but it's what greg's fileserver is doing so I don't feel too bad about it. Signed-off-by: Open592 Developer <uss@open592.com>
cfrank
force-pushed
the
feature/protocol-v2
branch
from
dde0224 to
ea9c576
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is pretty much a rip off of Grahams openrs2 implementation along with some items from Greg's file server. Been a good learning experience for when I re-implement it myself.
Still some more work to be done, but at least the protocol handling is on the right path.