Skip to content

feat: add source navigation, language assistance and local recovery - #5

Merged
rororowyourboat merged 3 commits into
developfrom
feature/source-assistance-recovery
Nov 1, 2026
Merged

rororowyourboat merged 3 commits into
developfrom
feature/source-assistance-recovery

Conversation

@rororowyourboat

@rororowyourboat rororowyourboat commented Nov 1, 2026 •

Copy link
Copy Markdown
Member

Source issues now navigate only into the exact draft snapshot that produced them. The source editor adds pinned-Toolkit completion, symbol information and project-file definitions; stale results and unsupported partial completion edits are rejected before they can change a draft.

Local recovery keeps one validated IndexedDB copy of applied source, drafts, positions and active file/view. Reload offers explicit restore/discard, restored work remains unsaved until download, and atomic compare-and-swap protects competing tabs. Storage/engine failures retain current work; discarded drafts and clean transitions cannot leave stale recovery. Portable bundle v1, engine pins and dependencies are unchanged.

README, capability, architecture and testing documents describe the supported scope and storage policy. The CI timeout grows from 20 to 30 minutes for the expanded real-engine suite. The header gains a contextual Local recovery action; 15 existing visual baselines change only within that header, with 8 new dialog/tooltip captures.

Validation:

  • npm run check: 118 Vitest + 5 Node tests; formatting, architecture and TypeScript passed.
  • Focused actual-engine language (4) and recovery (9) scenarios passed, including cancellation, asset failure/retry, CRLF/Unicode navigation, competing tabs and rejected restore.
  • Full functional suite: 74/74 passed in 11.9 minutes through a fresh production build, with no retries or skips.
  • Normal visual comparisons: 33/33 passed; new and intentionally changed screenshots inspected.
  • Focused and visual evidence is in docs/verification.md; a documentation-only follow-up will record the completed full functional run.
  • Hosted Validate passed for f708b84: https://github.com/Open-MBEE/sysml_view_editor/actions/runs/41314513339
  • Deliberate stale-result/startup-record/clean-transition/unsaved-baseline faults failed their targeted assertions, and restored code passed.

Firefox/WebKit and a complete accessibility audit are not covered. Unsupported non-string IndexedDB records remain retained and reported unavailable; malformed/future string envelopes support explicit discard.

@rororowyourboat
rororowyourboat marked this pull request as ready for review November 1, 2026 14:46
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-01T14:49:59.137502Z f708b84 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@rororowyourboat
rororowyourboat merged commit f3784ce into develop Nov 1, 2026
1 check passed
@rororowyourboat
rororowyourboat deleted the feature/source-assistance-recovery branch November 1, 2026 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant