Skip to content

Show source-backed values with readable views and explicit inspection - #38

Open
rororowyourboat wants to merge 5 commits into
developfrom
feature/source-values-inspection
Open

rororowyourboat wants to merge 5 commits into
developfrom
feature/source-values-inspection

Conversation

@rororowyourboat

Copy link
Copy Markdown
Member

Change

Configuration and evidence nodes previously lost authored values between the native renderer and browser projection. This change carries exact source expressions, providers and occurrence contexts through the validated worker contract and displays bounded previews with full Inspector details. Keyword-free redefinitions and distinct nested usage overrides are covered; unsupported binding/precedence paths are explained without inventing evaluated values.

Large authored views now enter at readable scale when a complete fit would fall below 60%. Fit view provides the overview and 100% focuses the inspected occurrence or port owner. Tree/table selection opens details, with source navigation as an explicit action guarded against changed drafts. Saved geometry, portable data and engine pins stay unchanged.

Fixes #24. Addresses the readability and inspection workflows in #30, #31 and #33. The structural column layout remains unchanged after bounded layout probes; general layout repacking and broader navigation feedback remain follow-up work, so those issues are not automatically closed.

Evidence

  • npm run check: formatting, architecture, TypeScript, 179 unit tests and 10 script tests passed.
  • Fresh production build and normal acceptance run: all 135 passed (42 functional, including all 26 critical paths, plus all 93 visual comparisons); no baseline updates, retries or skips.
  • Reviewed 66 changed and four new snapshots across desktop/narrow and light/dark; 58 existing images unchanged.
  • Original pinned ADCS models: four final browser scenarios covering all three target views at 1600/800 in both themes passed, including exact values, 100% entry, zero overview geometry hits and portable-data preservation.
  • Complete pinned Go bridge/engine suites passed, with retained failing controls for source scope, providers, keyword-free redefinitions, owner defaults and stale camera selection. Independent engine/UI reviews found and verified repairs; final source review found no confirmed blocker.

Full functional, Firefox/WebKit and comprehensive accessibility suites were not run. Local results do not establish hosted CI or deployment.

Compatibility

Derived worker metadata is additive and validated against applied source. No dependency, engine pin or saved-format change. No expression evaluation, generalized binding precedence, library source navigation or deployment is claimed. See docs/verification.md for exact pins, negative controls, review boundaries and retained evidence.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-11T13:07:25.143373Z 82e99bc PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show authored attribute values on overview and configuration nodes

1 participant