Repository navigation
fix: preserve inherited view members and scope recovery errors - #37
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
4 of 21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Authored interconnection views omitted inherited structural members from typed usages. Retain the native effective occurrences with exact declaration/usage correspondence, reserve legacy node/port IDs for positioned projects, and place newly visible inherited nodes within existing owner bounds without changing ordinary authored-node placement. Keyboard structural selection now updates Properties.
After accepting recovery, a visualization failure could enter the recovery error channel and survive a later successful action. Route that refresh through the generation-aware workbench action channel while preserving rejected-restore handling and current actionable errors.
Fixes #14. Fixes #18.
Also retain the #20 exposure investigation and executable upstream reproduction. Immediate exposure can legitimately include private imported memberships; a separate intermediate-import visibility defect remains unresolved. No unsafe resolver experiment is integrated and this PR does not close #20.
Evidence
npm run engines:prepare: complete combined Go bridge suite passed; 16 exact inherited-occurrence cases include negative controls for pruning and legacy-ID reservation.npm run check: formatting, architecture, TypeScript, 166 unit tests and 10 script tests passed.Fresh production builds ran through Playwright. Full functional coverage outside the recorded subsets, Firefox/WebKit, complete accessibility auditing and large-model performance were not run. Hosted CI for this PR and deployment are separate from local results.
Compatibility
Engine pins, dependencies and the version-1 saved project format are unchanged. The artifact contract validates the native optional inherited flag; it is not a persisted format field. Temporary exploration/tree ownership scope, attribute compartments and connector-selection policy remain unchanged. If saved geometry leaves no fitting slot for a new inherited node, the editor preserves saved positions and warns instead of inventing larger unsaved drag bounds. General manual overlap prevention is not provided.
This branch builds on merged recovery PR #36. The committed verification record and exposure investigation describe exact scope, engine provenance and unresolved findings.