Skip to content

feat: add native requirements and satisfaction diagrams - #10

Merged
rororowyourboat merged 19 commits into
developfrom
feature/requirements-traceability
Nov 5, 2026
Merged

rororowyourboat merged 19 commits into
developfrom
feature/requirements-traceability

Conversation

@rororowyourboat

@rororowyourboat rororowyourboat commented Nov 4, 2026 •

Copy link
Copy Markdown
Member

Change

Render native requirement views with dedicated definition/usage cards, declared identifiers and documentation, explicit typing/ownership, and positive or negated satisfaction links. Selection exposes exact relationship endpoints and source declarations, including anonymous satisfaction declarations and repeated names under different owners.

The existing named-view worker contract now carries validated AST-backed requirement metadata. Source remains authoritative; requirement diagrams allow browsing and presentation movement while semantic authoring controls stay disabled. Requirement graphs fit larger scopes, and pointer/keyboard movement preserves compatible version-1 geometry across reopen.

Evidence

  • npm run check: 141 Vitest tests and 10 Node checks passed, alongside formatting, architecture and TypeScript checks.
  • Fresh production builds passed; existing bundle-size warning remains.
  • npm audit --audit-level=low: no vulnerabilities.
  • Actual pinned worker/WASM evidence: 14 retained artifact validations; Go bridge tests and derived preparation passed.
  • Complete functional project: all 92 scenarios passed without retries or skips, including five requirements workflows and keyboard movement preservation.
  • Complete visual project: all 51 comparisons passed in 3.7 minutes without baseline updates, retries or skips. Zoom setup was normalized through visible controls after diagnosing differing initial fit scales; no existing baseline or comparison threshold changed.
  • Six new requirement captures reviewed at desktop/narrow sizes in both themes. Fault demonstrations detected swapped endpoints, incompatible representation reuse and missing negative-satisfaction text before restoration. The fit regression also failed before its fix.

Hosted Validate run 41772724358 passed for head a88e5da: 141 Vitest tests, ten Node checks, dependency audit, all 13 critical browser workflows and all 51 visual comparisons. The full 92-scenario functional result above is local evidence.

Detailed evidence and limitations: docs/verification.md. Firefox/WebKit and complete accessibility certification were not run.

Compatibility

No production dependency, upstream engine pin/checksum or saved-format version changed. Existing structural diagram families retain their zoom limits; the requirement renderer has a lower fit limit. Incompatible representation changes reject previous geometry instead of borrowing it.

The capacity and explicit traceability examples establish the native requirement subset. The compressor requirements view stays a generic tree. Declared satisfaction is model content, not an executed verification result; full standard notation, typed-instance trace expansion, automatic diagrams without authored views and generalized edge routing remain follow-ups. No production deployment is included.

Integration review — 2026-11-05

Reviewed against local develop (437cfc9): no concrete Standards or Spec findings. Commit ac7ee9f corrects a stale routing note to distinguish delivered requirement-edge interaction from planned structural/tree work; no application code changed.

  • npm run check passed again: formatting, architecture, TypeScript, 141 Vitest tests and 10 Node checks.
  • npm run test:e2e -- --project=functional requirements.spec.ts --output=sandbox/playwright/requirements-review-functional: all five scenarios passed (39.6 seconds), using a fresh production build and the pinned engines.
  • Inspected all six requirement baselines at desktop/narrow sizes in both themes; existing shared typing-edge paths remain a documented limitation.
  • npm run test:e2e -- --project=visual --output=sandbox/playwright/requirements-review-visual: stopped at the user's request to avoid redundant broad testing; 25 passed, one interrupted, 25 did not run. This is not a complete visual pass. No baselines or tolerances changed.
  • The earlier complete functional/visual evidence and hosted result above belong to a88e5da; they do not establish hosted CI for the new documentation commit. Full functional tests and dependency audit were not repeated in this review.

Local review logs: sandbox/requirements-review-check.log, sandbox/requirements-review-functional.log, sandbox/requirements-review-visual.log. These ignored files are not included in the PR.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-04T04:23:35.761322Z a88e5da PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@rororowyourboat
rororowyourboat merged commit 7b37ebe into develop Nov 5, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant