Repository navigation
feat: add native requirements and satisfaction diagrams - #10
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Render native requirement views with dedicated definition/usage cards, declared identifiers and documentation, explicit typing/ownership, and positive or negated satisfaction links. Selection exposes exact relationship endpoints and source declarations, including anonymous satisfaction declarations and repeated names under different owners.
The existing named-view worker contract now carries validated AST-backed requirement metadata. Source remains authoritative; requirement diagrams allow browsing and presentation movement while semantic authoring controls stay disabled. Requirement graphs fit larger scopes, and pointer/keyboard movement preserves compatible version-1 geometry across reopen.
Evidence
npm run check: 141 Vitest tests and 10 Node checks passed, alongside formatting, architecture and TypeScript checks.npm audit --audit-level=low: no vulnerabilities.Hosted Validate run 41772724358 passed for head
a88e5da: 141 Vitest tests, ten Node checks, dependency audit, all 13 critical browser workflows and all 51 visual comparisons. The full 92-scenario functional result above is local evidence.Detailed evidence and limitations:
docs/verification.md. Firefox/WebKit and complete accessibility certification were not run.Compatibility
No production dependency, upstream engine pin/checksum or saved-format version changed. Existing structural diagram families retain their zoom limits; the requirement renderer has a lower fit limit. Incompatible representation changes reject previous geometry instead of borrowing it.
The capacity and explicit traceability examples establish the native requirement subset. The compressor requirements view stays a generic tree. Declared satisfaction is model content, not an executed verification result; full standard notation, typed-instance trace expansion, automatic diagrams without authored views and generalized edge routing remain follow-ups. No production deployment is included.
Integration review — 2026-11-05
Reviewed against local
develop(437cfc9): no concrete Standards or Spec findings. Commitac7ee9fcorrects a stale routing note to distinguish delivered requirement-edge interaction from planned structural/tree work; no application code changed.npm run checkpassed again: formatting, architecture, TypeScript, 141 Vitest tests and 10 Node checks.npm run test:e2e -- --project=functional requirements.spec.ts --output=sandbox/playwright/requirements-review-functional: all five scenarios passed (39.6 seconds), using a fresh production build and the pinned engines.npm run test:e2e -- --project=visual --output=sandbox/playwright/requirements-review-visual: stopped at the user's request to avoid redundant broad testing; 25 passed, one interrupted, 25 did not run. This is not a complete visual pass. No baselines or tolerances changed.a88e5da; they do not establish hosted CI for the new documentation commit. Full functional tests and dependency audit were not repeated in this review.Local review logs:
sandbox/requirements-review-check.log,sandbox/requirements-review-functional.log,sandbox/requirements-review-visual.log. These ignored files are not included in the PR.