fix(view): label transition triggers by the name their signal or operation ends in - #563
Merged
Merged
Conversation
…ation ends in Co-Authored-By: jason.han <hanhuijun@gmail.com>
Co-Authored-By: jason.han <hanhuijun@gmail.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Contributor
Author
HuiJun
marked this pull request as ready for review
September 24, 2026 15:11
…n parameterless calls Co-Authored-By: jason.han <hanhuijun@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
A rendered state or action view labelled an
accepttrigger with the trigger's source text. A transition migrated from a Cameo model writes its signal fully qualified, so every such edge carried the whole path across the drawing (accept TMT::'02 JPL'::'System Model'::APS::…::Control::'Post-Segment Exchange Alignment'), overlapping the nodes and the other edges of any Cameo-positioned view. Node heads and types were already shortened to their end names; edge triggers were the one label left on the written text.triggerLabelnow heads an accept or call trigger by the name its signal or operation ends in, the way a node's type is headed, before falling back to the source text:The shortening happens in the shared renderer, so DOT, Mermaid, PlantUML and the text form,
-render,-render-alland document figures all pick it up.Use Case: Post-Segment Exchange Alignment(TMT,neato -n2on the Cameo positions), before and after:How it was verified
TestTriggerLabelsHeadTheirSignalByItsEndName(new): qualified signal, named payload, call trigger with arguments, and a time event; no edge label keeps a::.TestEdgeLabelsYieldToTheEdgesOwnTextand thestate.*goldens unchanged.go build ./...,go vet ./...,gofmt -l .empty,go test ./...green.'TMT-APS DDD Document'rendered to HTML under thenasatheme — 69accept TMT::…figure labels before, 0 after; every trigger label is now the bare signal name.Checklist
make testandmake lintpass locallychanges/unreleased/<slug>.<section>.md, not as an edit toCHANGELOG.mdmake docs-countsrun if a gate count moved (compliance rows need nothing: the census is counted at docs build)F4,K5) in the body, docs, or changelog