Repository navigation
docs(perf): account for every merge up to develop e022cbca0 in the 0.12.0 record - #1788
Merged
Merged
Conversation
….0 record The export rows are re-probed a second time at d01e4f4 (#1774: bytes and allocations equal to 5e0322e's on every row), the runtime, gRPC and REPL rows re-run six interleaved rounds at 1e34d9d against cc1d477 (#1777: nothing moved, bytes and allocations equal, the tests/perf binary's peak resident set within spread), the whole-binary element-ID probe repeated, and the candidate named as develop cf16528 with the SHA each row set was measured at. Co-Authored-By: jason.han <hanhuijun@gmail.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Contributor
Author
There was a problem hiding this comment.
🔍 Devin Review: 1 flag
Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
…at they are equal Co-Authored-By: jason.han <hanhuijun@gmail.com>
…s cost #1784 (Usage::mayTimeVary over the effective isComposite) is on the semantics path every load runs: six interleaved rounds against cc1d477 show the load rows +1.5 % bytes and +4.7–4.8 % allocations per element loaded (ImportValues/nested up to +13 % allocations), the runtime, instantiation and parser rows unchanged, sec/op unresolved; the record names the merge as the cause, not fixed here, and the candidate as develop 9a4ffcd. Co-Authored-By: jason.han <hanhuijun@gmail.com>
The RDF export fix touches internal/translate/export only, so the record re-runs the export rows (WriteAPIJSON, ConvertAPIJSON/32 and /128, the element-ID query, the Turtle export) six interleaved rounds at e022cbc against d01e4f4, names develop e022cbc as the candidate and keeps the #1784 load findings as reported. Co-Authored-By: jason.han <hanhuijun@gmail.com>
devin-ai-integration Bot
added a commit
that referenced
this pull request
Oct 31, 2026
….0 record Name develop df2bc17 as the candidate of the 0.12.0 performance record and account for each merge after e022cbc: #1793, #1794, #1787, #1788, #1752 and #1775 Go-neutral by diff; #1792 re-probed on the export rows at 86fa09e (neutral); #1795 and #1791 measured at a37809a on every row set (load and runtime rows unchanged, BatchSatisfy one allocation per assertion, export rows +0.1 %); Co-Authored-By: jason.han <hanhuijun@gmail.com> #1778 measured at df2bc17 on the runtime and gRPC rows (unchanged).
3 of 6 tasks
HuiJun
added a commit
that referenced
this pull request
Oct 31, 2026
* docs(perf): account for every merge up to develop df2bc17 in the 0.12.0 record Name develop df2bc17 as the candidate of the 0.12.0 performance record and account for each merge after e022cbc: #1793, #1794, #1787, #1788, #1752 and #1775 Go-neutral by diff; #1792 re-probed on the export rows at 86fa09e (neutral); #1795 and #1791 measured at a37809a on every row set (load and runtime rows unchanged, BatchSatisfy one allocation per assertion, export rows +0.1 %); Co-Authored-By: jason.han <hanhuijun@gmail.com> #1778 measured at df2bc17 on the runtime and gRPC rows (unchanged). * docs(perf): account for #1797 and #1785 in the 0.12.0 record, candidate develop d16ca71 Co-Authored-By: jason.han <hanhuijun@gmail.com> --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: jason.han <hanhuijun@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
#1740 landed the 0.12.0 performance record with the release candidate measured at
cc1d477baand the export rows re-probed at5e0322e0c.developkept moving while it was reviewed, and several of the merges touch measured paths, so the record's "The release candidate" section is amended to account for every merge up todevelope022cbca0:fix(export): read one relationship id per feature-chain clause,d01e4f49c) changesinternal/translate/export/element_ids.go: the export rows were re-probed a second time, six rounds interleaved with both 0.11.0 columns —WriteAPIJSONandConvertAPIJSONallocate the same bytes and the same number of times as at5e0322e0con every row, and the whole-binary element-ID probe was repeated against thecc1d477babinary.feat(engine): run state machines…,1e34d9d95) changesinternal/exec/runtime/context.goand the engine/gRPC frontends: six interleaved rounds of the runtime and gRPC packages, replLoadModeland thetests/perfrows,cc1d477baagainst1e34d9d95, steal logged per round — bytes and allocations equal on every exact row,InstantiateWarmModelinside its own spread, sec/op~, thetests/perfpeak resident set within spread.fix(semantics): Usage::mayTimeVary derives over the effective isComposite,9a4ffcd83) is on the semantics path every load runs: six interleaved rounds at9a4ffcd83againstcc1d477bashow it moves the load rows — replLoadModel/1000+1.5 % bytes and +4.8 % allocations per element loaded,ImportValues/nested+11–13 % allocations, the runtime and instantiation rows unchanged, sec/op~. The record names fix(semantics): Usage::mayTimeVary derives over the effective isComposite — a performed action or exhibited state varies in time #1784 as the cause (it takes back about a third of what perf(check): sweep a document's expressions for typed by only while one is unreported #1744 recovered on the load rows) and does not fix it.fix(export): the RDF export states a usage's isVariable and mayTimeVary as the metamodel does,e022cbca0) changes five files underinternal/translate/export: the export rows were re-probed a third time, six rounds ate022cbca0againstd01e4f49c— every row grows with its output (WriteAPIJSONoutput +0.4–2.2 %, bytes +0.06–0.57 %, allocations +0.3–0.9 %;ConvertAPIJSON/32and/128+0.7–0.8 % bytes, +1.2 % allocations, all p=0.002), sec/op~, the whole-binary element-ID query, Turtle export and-validatewithin spread.git diff --stat … -- '*.go' go.mod go.sum.The candidate is named as
develope022cbca0, with the SHA each row set was measured at (cc1d477ba, re-checked at1e34d9d95and9a4ffcd83, for the runtime/load/REPL/LSP/whole-binary rows;e022cbca0for the export rows), and the "What this record does not measure" list moves its cut accordingly. The changelog fragment of #1740 gains the words "with every merge up to the release head accounted for".How it was verified
python3 scripts/check-doc-links.pyreports only the pre-existingthird-party-notices.mdlink;python3 scripts/changelog.py checkpasses; every table in the record has consistent columns. The raw per-round outputs of every probe (steal logged per round, the whole-binary sequences, thetests/perfRSS runs) are kept outside the repository and attached to the gate report, as the rest of the record's are.Checklist
make testandmake lintpass locally — documentation only; no Go source changeschanges/unreleased/<slug>.<section>.md, not as an edit toCHANGELOG.md— the existingperf-0.12.0-record.added.mdfragment is amendedmake docs-countsrun if a gate count moved — no gate count movedF4,K5) in the body, docs, or changelogLink to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/15408827f8104c7fbbdbd1b2c852ed2c
Open in Devin Desktop: https://nasa-jpl-demo.devinenterprise.com/desktop/session/15408827f8104c7fbbdbd1b2c852ed2c?variant=devin
Requested by: @HuiJun