Skip to content

fix(referee): re-record baselines for the DocumentQueries library change - #1691

Closed
devin-ai-integration[bot] wants to merge 1 commit into
developfrom
fix/referee-baselines-document-queries
Closed

devin-ai-integration[bot] wants to merge 1 commit into
developfrom
fix/referee-baselines-document-queries

Conversation

@devin-ai-integration

Copy link
Copy Markdown
Contributor

What and why

develop is red at ade03595d: TestCommittedBaselineStatesThisRepositorysProvenance fails in tools/referee/apijson and tools/referee/diff (CI job Go race tests (rest), also the quick tier) with

provenance.inputs[opensysml-libraries].digest: baseline records "sha256:ac6a1e3b…", repository now has "sha256:29a3bf0f…"

#1689 (WhereType exact) gave DocumentQueries::WhereType a new in exact : Boolean[1] default false; parameter, which changed internal/workspace/libs/stdlib/OpenSysML Libraries/DocumentQueries.sysml, the opensysml-libraries input root of both committed baselines, without re-recording them. This PR re-records the two baselines with the repo's own tools and re-states the three figures in docs/project/api-json-differential.md that the re-record moved. No code changes.

Follow-up for the queue: open PR #1690 (Differ) changes the same libs files again, so after this PR lands #1690 must merge develop and re-record both baselines once more.

What moved

docs/project/pilot-differential-baseline.json

  • provenance.inputs[opensysml-libraries].digest: sha256:ac6a1e3b… → sha256:29a3bf0f…; provenance.recorded 2026-10-28 → 2026-10-29. Nothing else: 8 roots / 9 inputs as before, no file row, count or total moved (921 files, 519 fully agreeing; 1098 agreed, 359 only ours, 2462 only the pilot's).

docs/project/api-json-differential-baseline.json

  • provenance.inputs[opensysml-libraries].digest: same move; 9 roots / 10 inputs as before.
  • Scorecard rows, each −34 present-equal / +34 present-different (every other bucket unchanged):
    • InvocationExpression.parameter: 382 / 98 → 348 / 132
    • InvocationExpression.input: 368 / 96 → 334 / 130
  • Per root (elements, oursMissing, pilotMissing, absentBoth, indeterminate, pilotNondeterministic unchanged):
    • examples: present-equal 332702 → 332672, present-different 8290 → 8320 (15 WhereType( calls: self-model/document.sysml 8, analysis-results-demo/lander-results.sysml 6, external-tool-demo/thermal.sysml 1 — 15 × 2 properties = 30); pilotLibraryElements 15571 → 15648 (+77 = 7 files × 11)
    • manual-examples: present-equal 88779 → 88741, present-different 2034 → 2072 (19 WhereType( calls: cookbook.sysml 8, requirements.sysml 3, trace-4-program.sysml 2, traceability.sysml 2, observatory.sysml 1, trace-1-basic.sysml 1, trace-2-hierarchy.sysml 1, trace-3-derivation.sysml 1 — 19 × 2 = 38); pilotLibraryElements 17088 → 17209 (+121 = 11 files × 11)
    • totals follow: present-equal 1120886 → 1120818, present-different 27496 → 27564, pilotLibraryElements 37415 → 37613. The other seven roots did not move.

Why those objects, and whose effect it is. Checked directly by exporting examples/external-tool-demo/thermal.sysml with the pinned pilot once against the pre-#1689 library and once against the current one. For the WhereType(...) call (Reporting::ThermalRuns/InvocationExpression[0]/Feature[0]/InvocationExpression[0]) the pilot's parameter list grew 3 → 4 and input 2 → 3: the pilot synthesizes an implicit parameter for the defaulted exact even though the call does not pass it, while our writer lists only the parameters the call binds (3 / 2, unchanged). So each of the 34 WhereType calls moved those two properties from present-equal to present-different. That is the direct consequence of #1689's new defaulted parameter landing on a pre-existing writer gap (we do not emit implicit parameters for defaulted arguments the call leaves out; the Project(...) calls in the same files already show it), not develop drift. The pilotLibraryElements growth is the 11 new library elements the pilot writes for every file that loads DocumentQueries (WhereType::exact ReferenceUsage, its FeatureTyping, FeatureValue, LiteralBoolean, MultiplicityRange + LiteralInteger, the new Comment and the four memberships), identical per file.

docs/project/api-json-differential.md

  • Scorecard headline: 1120886 → 1120818 present-equal, 27496 → 27564 present-different.
  • Per-root table rows examples (332702 / 8290 → 332672 / 8320) and docs/manual/examples (88779 / 2034 → 88741 / 2072). No other row, prose or pilot-differential.md figure moved (make docs-counts reports both current).

How it was verified

Provisioned every input root first (download-spec-examples, download-pilot-corpora, download-training-examples, download-pilot-kerml-validator, download-pilot-sysml-validator, download-pilot-json-exporter), then:

go run -C tools ./cmd/pilot-diff -update          # 2m28s, recorded 8 roots / 9 inputs
go run -C tools ./cmd/pilot-apijson-diff -update  # 13m48s, recorded 9 roots / 10 inputs
make docs-counts                                   # ✓ Documentation counts and refereed figures are current
go test -C tools -count=1 ./referee/apijson -run TestRecordStatesTheBaselinesFigures   # ok

Gate on the branch:

go build ./...                       OK
go vet ./...                         OK
gofmt -l .                           (empty)
cd tools && go test -count=1 ./...   ok — all packages, incl. referee/apijson 1.898s, referee/diff 1.988s
go test -count=1 ./tests/hygiene/... ok 13.232s
python3 scripts/changelog.py check   exit 0

Checklist

  • make test and make lint pass locally (the gate above; no Go code changed)
  • Tests added or updated for the change — n/a, baseline re-record
  • Documentation extended where it already covers the surface (figures in docs/project/api-json-differential.md)
  • Changelog entry — none: baseline re-record of a measured record, no user-facing behaviour changed
  • baselines regenerated and make docs-counts run
  • No internal work-item labels in the body, docs, or changelog

Link to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/02c00bfac5574bdb91cc5179ca1fc86c
Open in Devin Desktop: https://nasa-jpl-demo.devinenterprise.com/desktop/session/02c00bfac5574bdb91cc5179ca1fc86c?variant=devin
Requested by: @HuiJun

WhereType gained a defaulted exact parameter, which moved the
opensysml-libraries input digest of both committed baselines and, in the
api-json differential, the InvocationExpression.parameter and .input rows
for the 34 WhereType calls under examples/ and docs/manual/examples.

Co-Authored-By: jason.han <hanhuijun@gmail.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration
devin-ai-integration Bot marked this pull request as ready for review October 29, 2026 16:36

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

Superseded: #1679 merged first (develop b835c3c) carrying the same re-record of both baselines for the opensysml-libraries digest plus its own examples digest, so this PR is now a no-op (recorded date only). Closing, not merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant