Repository navigation
feat(QVTS): add QVTS, the shape of a query result — Outcome and the QueryResult view - #21
Open
devin-ai-integration[bot] wants to merge 2 commits into
Open
devin-ai-integration[bot] wants to merge 2 commits into
devin-ai-integration[bot] wants to merge 2 commits into
Conversation
…ueryResult view QVTS: :QueryResult is a view that exposes the elements a query selected and states the query, its source, its Outcome (established, pathError, modelError) and its provenance. The declarations are those of examples/QVTS.sysml in Open-MBEE/qvts, as a library package with the non-normative notice this repository requires. No engine binding, so engine-contract.json is unchanged. Co-Authored-By: jason.han <hanhuijun@gmail.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
OpenSysML's query engine writes an answer as a view typed by QVTS::QueryResult and its renderer recognises that definition, so both names are bound by qualified name. Co-Authored-By: jason.han <hanhuijun@gmail.com>
5 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
libraries/QVTS.sysml, the library a query answer is written against:QVTS::QueryResultview exposes the elements a query selected (references, never copies) and states which query ran, over which source, with which outcome, and where the run's provenance record is. The outcome distinction (a value, a path error, a model error) is the one specified in Open-MBEE/qvtsdocs/qvts-core.md§2.doctext are those ofexamples/QVTS.sysmlin Open-MBEE/qvts. Two changes make it a library of this repository:packagebecamelibrary package, and the top-leveldocopens with the NON-NORMATIVE notice.engine-contract.jsongains two entries,QVTS(package) andQVTS::QueryResult(element): OpenSysML's result-view writer (internal/doc/queryexec/resultview.go) and its view renderer (internal/ir/view/queryresult.go) bind those two names by qualified name. Additions only;contractis not bumped.Also: the README table row, the regenerated
.meta.json, and "query results" in.project.json's description.Validation
./scripts/verify-pilot-pin.sh— pin verified (pilot 2026-08)../scripts/validate-libraries.sh—Validation clean: 0 errors, 0 warning(s);validation/allowed-warnings.txtuntouched../scripts/check-readme-table.sh,./scripts/write-project-meta.py --check,./scripts/build-kpar.py— all pass;./scripts/check-engine-contract.shpasses with the two new entries resolved againstlibraries/.QVTS.sysmltogether with Open-MBEE/qvts'sexamples/observatory.sysmlandexamples/result.sysml(aview heavyParts : QueryResultwithexposemembers and the four attributes redefined) reports no diagnostic, so the example result view resolves against the library as shipped here.Note for review
Open-MBEE/qvts carries no
LICENSEfile; this repository is Apache-2.0. The copied text is nine declarations and threedoccomments.A matching Open-MBEE/OpenSysML pull request re-pins its vendored copy to this library once it is merged.
Link to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/1cb9400fae2e41888d76085f38572ba4
Open in Devin Desktop: https://nasa-jpl-demo.devinenterprise.com/desktop/session/1cb9400fae2e41888d76085f38572ba4?variant=devin
Requested by: @HuiJun
🟢 Devin Review found nothing to fix · View findings · Follow Devin's work