Repository navigation
feat(DocumentQueries): Descendants takes relationships = true — walk ownership as KerML 8.3.2.1 defines it, ownedRelationship then the elements each relationship owns - #19
Merged
Conversation
…ownership as KerML 8.3.2.1 defines it, ownedRelationship then the elements each relationship owns A document query could reach a model's elements but none of the relationships that own them, nor the implied elements those own (connector ends, the conjugated port definition, a satisfy subject). The parameter defaults to false, so every existing query reads as before; the engine contract lists Descendants by name only. Closes #18. Co-Authored-By: Nicolas Rouquette <nicolas.f.rouquette@jpl.nasa.gov>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
NicolasRouquette
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #18.
DocumentQueries::Descendantswalks the owned members of each namespace, so a document query never sees the relationships that own a model's elements — memberships, specializations, typings, feature values, imports — nor the elements those own in turn (a connector's implied ends, a port definition's conjugated~P, a satisfy usage's subject parameter). KerML 8.3.2.1 defines ownership through exactly those relationships (ownedRelationship, thenownedRelatedElement), and a reflection view needs them.One optional parameter on the existing
calc def, defaultfalse, so every existing query reads as before:relationships = truewalksownedRelationship, then the related elements each relationship owns, recursively tomaxDepth; the doc comment states the semantics..meta.jsonis regenerated (write-project-meta.py: the unit's checksum).engine-contract.jsonlistsDocumentQueries::Descendantsby name only.internal/doc/queryexec/operations.go, with a test walking a part definition's memberships, typings and connector ends) is ready onfeat/descendants-relationships; its PR re-pins the vendored copy to this merge../scripts/validate-libraries.shon the pinned pilot,./scripts/check-readme-table.sh,./scripts/write-project-meta.py --check.Link to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/18ad47adf36f44e9b6824a4472f9678d
Open in Devin Desktop: https://nasa-jpl-demo.devinenterprise.com/desktop/session/18ad47adf36f44e9b6824a4472f9678d?variant=devin
Requested by: @NicolasRouquette