Introduce job result downloading with item walking and ref rewriting - #933
Open
soxofaan wants to merge 5 commits into
Open
Introduce job result downloading with item walking and ref rewriting#933soxofaan wants to merge 5 commits into
soxofaan wants to merge 5 commits into
Conversation
soxofaan
commented
Aug 12, 2026
| target: Union[Path, str] = None, | ||
| *, | ||
| rewrite_references: bool = True, | ||
| ) -> List[Path]: |
Member
Author
There was a problem hiding this comment.
expose other args:
- extra_link_rels_to_download
- download_collection_assets
- json style options
| """ | ||
|
|
||
| # TODO: make this a public API that users can implement for custom download behavior (e.g. download to S3, ...) | ||
| # TODO: API to warn about or skip existing/previously downloaded files? |
Member
Author
There was a problem hiding this comment.
TODO: API to skip download failures (after retries) and just warn?
|
|
||
| result_metadata_path = self._root_path / DEFAULT_JOB_RESULTS_FILENAME | ||
| # Initial write of metadata, will possibly be updated later if rewrite_references is True | ||
| self._json_dump(data=result_metadata, path=result_metadata_path) |
Member
Author
There was a problem hiding this comment.
give initial file a ".inprogress" suffix?
and only swap to final filename at the end
| self._connection = job.connection | ||
| self._root_path = Path(target or Path.cwd() / job.job_id) | ||
| self._rewrite_references = rewrite_references | ||
| self._downloaded = [] |
Member
Author
There was a problem hiding this comment.
Use this list of downloaded files to avoid overwrites
| requests_mock.get(item_href, json=item_doc) | ||
| return item_href | ||
|
|
||
| def setup(*, job_id="job-123", items: dict, api_url: str = API_URL): |
Member
Author
There was a problem hiding this comment.
make this a class instead of closured functions
…ng and ref rewriting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref #931