small fixes to status management in JobManager#872
Merged
Conversation
Contributor
Author
|
scaling up before: scaling up after |
HansVRP
approved these changes
Mar 23, 2026
soxofaan
reviewed
Mar 23, 2026
| queued = running[running["status"] == "queued"] | ||
| queued = running[ | ||
| running["status"] != "running" | ||
| ] # The queue limit is for non-running jobs, so we need to exclude running jobs from the queued count |
Member
There was a problem hiding this comment.
isn't the queue limit about queued jobs?
with this change "created" jobs will also be counted as "queued" which makes no sense to me.
Or even worse: "finished" and "error" jobs will also count as "queued" here
Contributor
Author
|
PR has been reverted and will be taken up in #873 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PRevents overwriting local status queued_for_start with backend status created
Takes account of the jobs in created and queued_for_start for the queue limit on a backend