docs: finish the README dark-mode assets - #438
Merged
Merged
Conversation
GitHub markdown sets max-width: 100% on images but never height: auto, so an explicit height attribute keeps the box at that height while the width shrinks to the README column. The banner was the only image in the file carrying one, so it rendered 768x500 in the column instead of 768x384: the artwork and its headline came out 30% taller than designed. Reproduced the rule locally at a 768px column: width+height renders 768x500 (ratio 1.536 against the natural 2.000), width alone renders 768x384 (ratio 2.000). A template match against the artwork on the live page agreed with the stretched case (0.48 horizontal scale, 0.58 vertical). Dropping the attribute makes the banner behave like every other figure in the file, which set width only.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
max-width: 100%on imagesbut never
height: auto, so theheight="500"attribute kept the box at 500pxwhile the width shrank to the README column: the artwork and its headline
rendered 768x500 instead of 768x384, a 30% vertical stretch. The attribute is
gone and no image in the file sets a height anymore.
composition).
the Step 2 section. Every figure in the README now follows the reader color
scheme through
<picture>.Verification
width="1000" height="500"renders 768x500 (ratio 1.536 against the natural 2.000);
width="1000"alonerenders 768x384 (ratio 2.000). A template match of the artwork in a live page
screenshot agreed with the stretched case: 0.48 horizontal scale against 0.58
vertical.
checked-in files: the parsing pair reads "Two tracks. One navigable memory.", the
retrieval pair reads "Any agent. One memory contract."
README.mdresolves, and each dark/light pairshares one canvas (banner 3200x1600, diagrams 3200x1280, benchmark 3200x2240).
git diff --checkis clean.preview.
Deployment Notes
knowhere-banner-light.pngandknowhere-banner-dark.pngbecome.jpgat the same base names, and two-dark.pngfigures are added. External pages hot-linking the old PNG bannerpaths would break.
Checklist