feat(retrieval): compose evidence in Knowhere and keep raw results for debug - #430
Merged
Merged
Conversation
- Added a new `evidence` field to the `RetrievalQueryResponse` model to include composed evidence parts (text and inline images). - Updated the MCP response projection to return the new `evidence` field alongside `evidence_text`. - Refactored evidence rendering logic to flatten composed parts and improve the assembly of retrieval results. - Adjusted tests to validate the new evidence structure and ensure proper handling of composed evidence in responses.
…handling - Removed the deprecated `render_evidence_blocks` function and replaced it with a new internal function `_render_evidence_blocks` for improved clarity and functionality. - Updated the `_try_read_page_image` and `_select_page_asset` functions to return additional warnings for better error handling when page images are unavailable or mismatched. - Refactored the `flatten_parts` function to utilize the new `page_summary` utility for summarizing page content. - Enhanced tests to validate the new image handling logic and ensure proper warnings are displayed when images are missing or do not match expected page numbers.
Public results stay raw for debug; composed parts live only on evidence. MCP query now returns the same package. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
evidence/evidence_text.resultsas raw path chunks with placeholders for debug.retrieval.queryto the same outgoing package.Test plan
make checkpytest packages/shared-python/shared/testspytest apps/api/testsMade with Cursor