feat(retrieval): explore tables/images and align GREP to term index - #428
Merged
Merged
Conversation
- Introduced `FinishRefResolution` class to encapsulate resolved and dropped references during the finish resolution process. - Updated `resolve_finish_refs` to return an instance of `FinishRefResolution`, providing detailed feedback on reference handling. - Implemented `select_episode_refs` to manage fallback logic for episode references, ensuring explicit empty lists are respected. - Enhanced tests to cover new functionality, including scenarios for omitted and explicit references. - Refactored related components to integrate the new reference resolution structure, improving clarity and maintainability.
…dling - Added `beautifulsoup4` as a dependency for HTML parsing. - Introduced new constants for large table handling and focus radius in settings. - Enhanced `cursor_execute_content` to include HTTPS image parts in responses. - Updated `recall` and `read` tools to support rendering of images and tables, including handling of large tables and their focus windows. - Improved tests to validate new functionalities, including image handling and table queries.
- Removed the focus radius setting and related logic from the table handling process. - Updated the `load_table_html` function to raise a `TableDownloadError` on download failures, allowing for better error handling. - Adjusted the `read` and `query_table` functions to handle table download errors gracefully, ensuring that body content is still returned even if a table fails to load. - Enhanced tests to cover scenarios for table download failures and ensure proper error messages are returned. - Refactored related components to improve clarity and maintainability in table processing.
Declare download_raw_to_temp on the storage protocol, narrow BeautifulSoup tags, and count cited finish refs so make check stays green. Co-authored-by: Cursor <cursoragent@cursor.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| from alembic import op | ||
|
|
||
| revision: str = "1a2b3c4d5e6f" |
| from alembic import op | ||
|
|
||
| revision: str = "1a2b3c4d5e6f" | ||
| down_revision: str | Sequence[str] | None = "0b1c2d3e4f5a" |
|
|
||
| revision: str = "1a2b3c4d5e6f" | ||
| down_revision: str | Sequence[str] | None = "0b1c2d3e4f5a" | ||
| branch_labels: Sequence[str] | None = None |
| revision: str = "1a2b3c4d5e6f" | ||
| down_revision: str | Sequence[str] | None = "0b1c2d3e4f5a" | ||
| branch_labels: Sequence[str] | None = None | ||
| depends_on: Sequence[str] | None = None |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
query_table; no cell-focus window. Table download failure no longer fails the whole GREP/read call.query_tableas looked-at evidence, matching read/assets.Test plan
make checkMade with Cursor