Reject duplicate source filenames on new document ingest - #426
Merged
Merged
Conversation
- Added a new method to reject duplicate source file names during document ingestion. - Integrated the duplicate filename check into the job creation process to prevent conflicts. - Introduced helper functions for finding active documents by source file name and raising appropriate exceptions. - Enhanced tests to verify conflict handling for duplicate file names across different scenarios.
The full create_v1/v2 unit path queried jobs during scope resolution, so the sqlite fixture failed in CI. Co-authored-by: Cursor <cursoragent@cursor.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
source_file_name.document_id; same name is still allowed across namespaces, other users, and archived documents.409 ALREADY_EXISTSwith the existing document id so the client can retry as an update.Test plan
make checkpytest apps/api/tests/unit/test_document_ingestion_duplicate_filename.pyMade with Cursor