feat: add support for overriding OneSignal script src #132
Merged
sherwinski merged 3 commits intomainfrom Feb 23, 2026
Merged
Conversation
`ONE_SIGNAL_SCRIPT_SRC` is hardcoded to the CDN URL meaning that users with strict COEP/CSP headers cannot load it. This commit enables support for overriding the script src for users who wish to self-host the SDK script. It's worth noting that this change will cause the SDK script to be loaded at init() time instead of module-import time. Fixes OneSignal/react-onesignal#145
fadi-george
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enables support for overriding the script src for users who wish to self-host the SDK script. Fixes OneSignal/react-onesignal#145
Details
ONE_SIGNAL_SCRIPT_SRCis hardcoded to the CDN URL meaning that users with strict CSP headers cannot load it. This PR enables support for overriding the src URL for users who wish to self-host the SDK script themselves.It's worth noting that this change will cause the SDK script to be loaded at
init()time instead of module-import time, which is worth discussing.