Repository navigation
feat(blockstate): add the rule based blockstate editor - #332
Open
theEvilReaper wants to merge 36 commits into
Open
theEvilReaper wants to merge 36 commits into
theEvilReaper wants to merge 36 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Blockstates get their own section next to items, sounds and the other models. Each one belongs to a block and holds a list of rules that decide which model is shown for which state of that block, optionally rotated and with a name to tell the rules apart. A new blockstate is created by entering a name and picking the block in the same dialog, after which the rules are edited on cards and saved through the header like on the other detail pages. Several blockstates may target the same block, so the editor loads all of them and warns when two of them claim the same state. Everything is stored in the backend now instead of only living in memory as it did in the first prototype.
Types of changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any ofthem, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.