Skip to content

feat(color)!: add TeamColor mapping and rename ambiguous constants - #71

Merged
Joltras merged 2 commits into
mainfrom
feature/teamColor
Jul 25, 2026
Merged

feat(color)!: add TeamColor mapping and rename ambiguous constants#71
Joltras merged 2 commits into
mainfrom
feature/teamColor

Conversation

@theEvilReaper

Copy link
Copy Markdown
Contributor

Proposed changes

Adds ColorData#toTeamColor() to map colors onto Minestom's new TeamColor enum, resolved via NamedTextColor rather than enum name to avoid mismatches. Renames three ambiguous constants (GREEN→DARK_GREEN, LIGHT_GREEN→GREEN, PURPLE→DARK_PURPLE) so enum names match their actual NamedTextColor, which is a breaking change for any consumer referencing the old names.

Types of changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING.md
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@theEvilReaper theEvilReaper self-assigned this Jul 25, 2026

@TheMeinerLP TheMeinerLP left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Joltras
Joltras merged commit 700ed10 into main Jul 25, 2026
5 checks passed
@Joltras
Joltras deleted the feature/teamColor branch July 25, 2026 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants