Skip to content

refactor: player collection usage - #68

Merged
theEvilReaper merged 4 commits into
developfrom
feature/player-collection-improvements
Jul 24, 2026
Merged

refactor: player collection usage#68
theEvilReaper merged 4 commits into
developfrom
feature/player-collection-improvements

Conversation

@theEvilReaper

Copy link
Copy Markdown
Contributor

Proposed changes

Currently, ItemShiftOption and Joinables require a List of players for certain methods. This unnecessarily restricts the API, as other collection types cannot be used. This pull request changes the affected methods to accept a Collection instead, making the API more flexible

Types of changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING.md
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@theEvilReaper theEvilReaper self-assigned this Jul 23, 2026
@theEvilReaper
theEvilReaper force-pushed the feature/player-collection-improvements branch from c374bf0 to e70ffe8 Compare July 23, 2026 07:44
@theEvilReaper
theEvilReaper merged commit 3242f15 into develop Jul 24, 2026
1 check passed
@theEvilReaper
theEvilReaper deleted the feature/player-collection-improvements branch July 24, 2026 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant