feat(season): restart the lobby into a seasonal world during its window - #321
Merged
Merged
Conversation
Contributor
Test results 255 files 255 suites 17m 14s ⏱️ Results for commit 2c68de8. |
This was referenced Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A season is its own world, built by the build team as
worlds/<name>/with a map file. The lobby restarts into that world while the season window is active.seasons.<id>.{world,from,to,enabled}andseasons.zone(defaultEurope/Berlin).features/season, cloudnet variant only. The local variant excludes it because nothing there would restart the lobby.How it works
LobbyWorldChoice(incore), resolved byServiceLoaderinPlatformBeans.MinecraftServer.stopCleanly()only when nobody is online, and CloudNet restarts it.enabledkill switch use the same path.Why this shape
docs/lobby-season-spec, never inmain.ServiceLoaderinstead of an Avaje bean: a spike showed a bean from the column is always empty whenruntimebuildsMapProvider(the column requires runtime beans). A separate module would force column-to-column imports.Trade-offs
/stop.LobbyWorldChoiceaborts startup.Out of scope (later changes)
Navigator icons, chat prefix, block/display/sound effects, stages/preview,
/season list, player notice, local variant.Tests
MapPoolTest, LobbyWorldResolutionTest, SeasonCalendarTest, SeasonConfigReaderTest, RestartPolicyTest, SeasonModuleTest (Cyano Env, injected Clock,
env.tick()), SeasonWorldChoiceTest, VariantStartTest (both variants), SeasonLobbyWorldTest, SeasonRestartWiringTest (real BeanScope), SeasonMapFileNameTest../gradlew buildis green.Not tested: a real CloudNet restart cycle.
OpenSpec
Change:
openspec/changes/seasonal-lobby-worldhttps://claude.ai/code/session_01A7aAe2E6wAEbi6jjnyPTWH