feat(daytime): follow the real wall clock in the lobby - #319
Merged
Merged
Conversation
Contributor
Test results 222 files 222 suites 15m 18s ⏱️ Results for commit f7014e9. |
This was referenced Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
New column
features/daytime: the lobby time follows the wall clock ofdaytime.zone(defaultEurope/Berlin) linearly (06:00 -> 0, 12:00 -> 6000, 18:00 -> 12000, 00:00 -> 18000). It is updated once per second via the Minestom scheduler, and Minestom's own day cycle is stopped withdefaultClock().rate(0f).Configuration
daytime.enabled: kill switch; when off, the lobby goes back to midday (6000).daytime.zone: the time zone the clock is read in.Both are read on every run, so they apply live with the avaje-config watcher. An invalid zone aborts startup and names
daytime.zone; at runtime the last valid zone is kept and a warning is logged once.Notes
MapProvider's midday freeze stays as the fallback for variants without the column; no bean ordering is needed.time.jsonand the strategy interfaces are deliberately out of scope (a solar mapping could follow as a separate feat). feat: run the lobby on real Berlin time and seasons (Stage 2) #217 will be closed with a reference once this is merged.openspec/changes/realtime-lobby-daytime(capabilitylobby-daytime).Tests
:features:daytime:DayTimeMappingTest(unit, including both Berlin DST transitions),DaytimeModuleTest(Cyano Env, adjustable Clock,env.tick()),ColumnArchitectureTest../gradlew buildis green.https://claude.ai/code/session_01A7aAe2E6wAEbi6jjnyPTWH