Skip to content

chore(config): simplify game configuration - #274

Merged
theEvilReaper merged 5 commits into
mainfrom
refactor/game-config
Sep 25, 2026
Merged

theEvilReaper merged 5 commits into
mainfrom
refactor/game-config

Conversation

@theEvilReaper

@theEvilReaper theEvilReaper commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Proposed changes

The game configuration was spread over several classes that mostly passed the same values around, which made every new setting tedious to add. It is now one config grouped by feature, so each part of the game only gets the settings it actually uses and every value is checked right when it is created. Two settings that were no longer used anywhere are gone, while existing config files keep working without changes

Types of changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING.md
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@theEvilReaper theEvilReaper self-assigned this Sep 25, 2026

@TheMeinerLP TheMeinerLP left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theEvilReaper theEvilReaper changed the title chore(config): simplify the game configuration chore(config): simplify game configuration Sep 25, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Test results

  387 files    387 suites   3m 26s ⏱️
  663 tests   658 ✅  5 💤 0 ❌
1 992 runs  1 977 ✅ 15 💤 0 ❌

Results for commit 52ba173.

@theEvilReaper
theEvilReaper merged commit da008db into main Sep 25, 2026
7 of 8 checks passed
@theEvilReaper
theEvilReaper deleted the refactor/game-config branch September 25, 2026 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants