Skip to content

feat(page): make page amount calculation more dynamic - #257

Merged
theEvilReaper merged 16 commits into
mainfrom
feature/pageSpawn
Sep 25, 2026
Merged

theEvilReaper merged 16 commits into
mainfrom
feature/pageSpawn

Conversation

@theEvilReaper

@theEvilReaper theEvilReaper commented Sep 9, 2026 •

Copy link
Copy Markdown
Contributor

Proposed changes

Currently, the game calculates the number of pages using a fixed value and multiplication. This is not a good approach, as some cases require more pages. This pull request updates the calculation to make it more dynamic.

Types of changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING.md
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@theEvilReaper theEvilReaper self-assigned this Sep 9, 2026
@github-actions

github-actions Bot commented Sep 9, 2026 •

Copy link
Copy Markdown
Contributor

Test results

  390 files    390 suites   2m 49s ⏱️
  672 tests   667 ✅  5 💤 0 ❌
2 019 runs  2 004 ✅ 15 💤 0 ❌

Results for commit 2e95ce7.

♻️ This comment has been updated with latest results.

@theEvilReaper
theEvilReaper force-pushed the feature/pageSpawn branch 2 times, most recently from fa93f12 to 158c1ee Compare September 25, 2026 06:48
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@theEvilReaper
theEvilReaper merged commit c8774be into main Sep 25, 2026
11 of 12 checks passed
@theEvilReaper
theEvilReaper deleted the feature/pageSpawn branch September 25, 2026 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant