[Snyk] Security upgrade jsrsasign from 8.0.24 to 11.1.1#29
[Snyk] Security upgrade jsrsasign from 8.0.24 to 11.1.1#29revan-zhang wants to merge 1 commit intomasterfrom
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-JSRSASIGN-15370941 - https://snyk.io/vuln/SNYK-JS-JSRSASIGN-15370940 - https://snyk.io/vuln/SNYK-JS-JSRSASIGN-15370938 - https://snyk.io/vuln/SNYK-JS-JSRSASIGN-15371175 - https://snyk.io/vuln/SNYK-JS-JSRSASIGN-15370939 - https://snyk.io/vuln/SNYK-JS-JSRSASIGN-15371176
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
| "handshake-util": "1.2.0", | ||
| "javascript-biginteger": "0.9.2", | ||
| "jsrsasign": "^8.0.19", | ||
| "jsrsasign": "^11.1.1", |
There was a problem hiding this comment.
🔴 package-lock.json not updated to match new jsrsasign version range
The package.json bumps jsrsasign from ^8.0.19 to ^11.1.1, but libs/combined/package-lock.json still pins jsrsasign to version 8.0.24 (libs/combined/package-lock.json:5061-5064). Version 8.0.24 does not satisfy the new ^11.1.1 range (different major version). This means npm ci will fail due to the mismatch between package.json and package-lock.json, and the security fix this PR intends to deliver will not actually be installed in reproducible builds.
Prompt for agents
Run `npm install` (or `npm i`) inside the libs/combined directory to regenerate the package-lock.json file so that it resolves jsrsasign to a version satisfying ^11.1.1. Then commit the updated libs/combined/package-lock.json alongside the package.json change. Without this, `npm ci` will fail and the intended version upgrade will not take effect.
Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| "handshake-util": "1.2.0", | ||
| "javascript-biginteger": "0.9.2", | ||
| "jsrsasign": "^8.0.19", | ||
| "jsrsasign": "^11.1.1", |
There was a problem hiding this comment.
Lock file not updated, security fix ineffective
High Severity
The package-lock.json was not updated alongside this package.json change. The lockfile still pins jsrsasign at 8.0.24 (the vulnerable version), so npm ci will either fail due to the mismatch or continue installing the vulnerable version. Additionally, jsrsasign is not directly imported in index.js — it's only consumed as a transitive dependency of elastos-wallet-js, which requires ^8.0.12. Since ^11.1.1 doesn't satisfy ^8.0.12, npm will still install a vulnerable 8.x copy nested under elastos-wallet-js, meaning the security fix does not actually protect the code that uses the library.


Snyk has created this PR to fix 6 vulnerabilities in the npm dependencies of this project.
Snyk changed the following file(s):
libs/combined/package.jsonVulnerabilities that will be fixed with an upgrade:
SNYK-JS-JSRSASIGN-15370941
SNYK-JS-JSRSASIGN-15370940
SNYK-JS-JSRSASIGN-15370938
SNYK-JS-JSRSASIGN-15371175
SNYK-JS-JSRSASIGN-15370939
SNYK-JS-JSRSASIGN-15371176
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.
Note
Medium Risk
Upgrades a cryptography dependency across a major version, which could introduce subtle behavioral/compatibility changes in any signing/verification usage despite being a targeted dependency-only change.
Overview
Updates
libs/combined/package.jsonto upgradejsrsasignfrom^8.xto^11.1.1as a security remediation, leaving the rest of the dependency set unchanged.Written by Cursor Bugbot for commit 2a48161. This will update automatically on new commits. Configure here.