Aseem - Phase 2 - Add filters for Predicted vs Actual Cost Line chart and UI changes - #5403
Open
aseemdeshmukh wants to merge 3 commits into
Open
Aseem - Phase 2 - Add filters for Predicted vs Actual Cost Line chart and UI changes#5403aseemdeshmukh wants to merge 3 commits into
aseemdeshmukh wants to merge 3 commits into
Conversation
… and fixed dark mode compatibility
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
kzou55
requested changes
Jul 25, 2026
kzou55
left a comment
kzou55
left a comment
There was a problem hiding this comment.
Hi Aseem,
I ran and tested the PR locally.
Verified
-
Start Date and End Date filters work
-
Reset filters work
Recording.2026-07-25.144523.mp4
-
Pie chart have numeric values and percentages on pie charts (Labor, Equipment, Materials).
-
Color overall seems consistent across the charts
Issues
- Only 1 project available in the project filter. Need more projects to fully test if the filter is working
- Filters(project, start date, end date, and reset) can be better aligned and same size.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacement PR for PR #5375
Description
This PR covers/solves both of these similar tasks:
And also this task:
Related PRS (if any):
This frontend PR is related to the #4354 and #5375
Main changes explained:
How to test:
a) For dark mode, tooltips and texts are readable and can be distinguished --> * tooltip explanations for Planned, Actual, and Predicted costs exist
b) Filters for Projects and date filter work
c) reset filter button works
d) custom tooltip is working
e) There are numeric values and percentages on pie charts (Labor, Equipment, Materials).
f) Highlight cost overruns/underspends using color indicators or badges.
g) Ensure consistent color mapping across all charts (same color = same cost type).
Screenshots or videos of changes:
DemoAddFiltersFinancialTracking.mp4