Shravya/bugfix/duplicate_pagination_4196#5204
Open
ShravyaKudlu wants to merge 4 commits intodevelopmentfrom
Open
Shravya/bugfix/duplicate_pagination_4196#5204ShravyaKudlu wants to merge 4 commits intodevelopmentfrom
ShravyaKudlu wants to merge 4 commits intodevelopmentfrom
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Fixes #4196


821 Phase - 3: Fix Comment Duplication, Improve Pagination, and Allow Multiple Replies to Stay Open Related PR: #4196
Related PRS (if any):
This frontend PR is related to the development backend PR.
Main changes explained:
Duplicate prevention - Added ID check before appending:
const existingIds = new Set(comments.map(c => c.id));
const newComments = result.comments.filter(c => !existingIds.has(c.id));
Unique IDs - Changed from 100 + page * 10 + 1 to (page - 1) * 1000 + page * 2 to prevent collisions
Total count - Now accumulates instead of replacing:
setTotalComments(prevTotal => prevTotal + newComments.length);
Reply interactions - Already worked correctly with comment IDs, no changes needed
How to test:
npm installand...to run this PR locallyScreenshots or videos of changes:
Note:
Include the information the reviewers need to know.