Sayali : pass reviewerCount and reviewerNames to PR grading screen for DB…#5203
Open
sayali-2308 wants to merge 1 commit intodevelopmentfrom
Open
Sayali : pass reviewerCount and reviewerNames to PR grading screen for DB…#5203sayali-2308 wants to merge 1 commit intodevelopmentfrom
sayali-2308 wants to merge 1 commit intodevelopmentfrom
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #33 (Priority High) - Follow-up fix for PR Grading Screen: DB configs now show correct reviewer count
Related PRs:
Follow-up to merged PR #4935 (Sayali - add Create Test Configuration button and modal to PR Grading Screen)
Main changes explained:
PRGradingTest.jsxto storereviewerCountandreviewerNamesin dynamic team objects fetched from DBPRGradingScreen/index.jsxto generate correct number of reviewers from DB config when a non-static team is selectedHow to test:
Sayali_Fix_PRGrading_ReviewerCountnpm install&&npm run start:local/pr-grading-test+ Create Test Configurationwith Reviewer Count = 4 and some reviewer namesScreenshots or videos of changes:
1.Config list showing "testingnumber" with 5 reviewers:
2.Grading screen showing exactly 5 reviewers (Alice, Bob, Prajwal, Sayali, Reviewer 5)
Note:
Fix for reviewer feedback on PR #4935 - DB configs were always showing 8 reviewers (from default static team1) because reviewerCount was not being passed to the grading screen.