Sayali: replace hardcoded API URL with ENDPOINTS and improve network err…#5201
Open
sayali-2308 wants to merge 1 commit intodevelopmentfrom
Open
Sayali: replace hardcoded API URL with ENDPOINTS and improve network err…#5201sayali-2308 wants to merge 1 commit intodevelopmentfrom
sayali-2308 wants to merge 1 commit intodevelopmentfrom
Conversation
…or handling in HelpModal
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #22 (Priority Medium) - Follow-up fix for HGN Questionnaire Dashboard: Help Request Submission
Related PRs:
Follow-up to merged PR #4844 (Sayali - Add: Success and Error Feedback to Help Request Submission)
Main changes explained:
http://localhost:4500/api/helprequest/createURL withENDPOINTS.HELP_REQUEST_CREATEinHelpModal.jsxHELP_REQUEST_CREATEendpoint tosrc/utils/URL.jsHelpModal.jsxHow to test:
Sayali_Fix_HelpModal_Network_Errornpm installandnpm run start:local/hgnhelp##Screenshots
2.Backend stopped → modal showing "Failed to load help categories" + disabled Submit button
Note:
This fixes the reviewer's reported issue where "Failed to submit" error appeared when backend was stopped, caused by hardcoded localhost URL bypassing the Vite proxy.